Re: RTSP support for kernels >= 2.6.20

[Patrick McHardy <kaber@trash.net>]

Michael Guntsche wrote:
> 
> On Apr 16, 2007, at 15:15, Michael Guntsche wrote:
> 
>>
>> I am sorry, I just wanted to keep the size down.
>> I was able to make some progress today. Both modules compiled and I 
>> see that at least part of it is working.
>> One of the parts of the code I was not able to port is this.
> 
> 
> Answering my own E-Mail. I found my problem with the struct for the  tuple.
> 
> exp->tuple = ((struct nf_conntrack_tuple)
>         {
>           { ct->tuplehash[!dir].tuple.src.u3,
>             { 0 },
>           },
>           {
>             ct->tuplehash[!dir].tuple.dst.u3,
>             { .udp = { htons(expinfo.loport) } },
>             IPPROTO_UDP
>           }
>         });
> 
> This worked. I was not able to get the ->mask correctly though. For 
> testing purposes I used this.
> 
> 
> exp->mask = ((struct nf_conntrack_tuple)
>         {
>           { ct->tuplehash[!dir].tuple.src.u3,
>             { 0 }
>           },
>           {
>             ct->tuplehash[!dir].tuple.src.u3,
>             { .udp = { 0xFFFF } }, 0xFF
>           }
>         });
> 
> and it worked with several test streams. I am pretty sure that this  is
> completely wrong though and I would appreciate an< hints/tips on  how to
> get this right.
> If this is fixed I'll start cleaning everything up and send a patch  to
> the list.


In case you're porting it to nf_conntrack (which is the only thing that
makes sense since ip_conntrack will be gone in 2.6.22), I'd suggest
you use nf_conntrack_expect_init().