From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Date: Wed, 03 Jan 2018 16:16:08 +0100 Message-ID: <4624388.pPJCIclP0U@amdc3058> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joe Perches Cc: linux-fbdev@vger.kernel.org, David Airlie , Heiko Carstens , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Jaroslav Kysela , Peter Ujfalusi , linux-s390@vger.kernel.org, linux-omap@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Takashi Iwai , Sebastian Ott , James Smart , Cezary Jackiewicz , linux-serial@vger.kernel.org, Jiri Slaby , Darren Hart , Zhang Rui , Dick Kennedy , Mathias Nyman , linux-pm@vger.kernel.org, Peter Oberparleiter , intel-gfx@lists.freedesktop.org, Eduardo Valentin List-Id: alsa-devel@alsa-project.org T24gVHVlc2RheSwgRGVjZW1iZXIgMTksIDIwMTcgMTA6MTU6MDcgQU0gSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gQ29udmVydCBERVZJQ0VfQVRUUiB1c2VzIHRvIERFVklDRV9BVFRSX1JXIHdoZXJlIHBv c3NpYmxlLgo+IAo+IERvbmUgd2l0aCBwZXJsIHNjcmlwdDoKPiAKPiAkIGdpdCBncmVwIC13IC0t bmFtZS1vbmx5IERFVklDRV9BVFRSIHwgXAo+ICAgeGFyZ3MgcGVybCAtaSAtZSAnbG9jYWwgJC87 IHdoaWxlICg8PikgeyBzL1xiREVWSUNFX0FUVFJccypcKFxzKihcdyspXHMqLFxzKlwoPyhccypT X0lSVUdPXHMqXHxccypTX0lXVVNSfFxzKlNfSVdVU1JccypcfFxzKlNfSVJVR09ccyp8XHMqMDY0 NFxzKilcKT9ccyosXHMqXDFfc2hvd1xzKixccypcMV9zdG9yZVxzKlwpL0RFVklDRV9BVFRSX1JX KFwxKS9nOyBwcmludDt9Jwo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvZSBQZXJjaGVzIDxqb2VAcGVy Y2hlcy5jb20+Cj4gLS0tCj4gIGFyY2gvczM5MC9rZXJuZWwvdG9wb2xvZ3kuYyAgICAgICAgICB8 ICAzICstLQo+ICBhcmNoL3RpbGUva2VybmVsL3N5c2ZzLmMgICAgICAgICAgICAgfCAgMiArLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMgICAgfCAgNiArKy0tLQo+ICBkcml2 ZXJzL3BsYXRmb3JtL3g4Ni9jb21wYWwtbGFwdG9wLmMgfCAxOCArKysrKy0tLS0tLS0tLS0KPiAg ZHJpdmVycy9zMzkwL2Npby9kZXZpY2UuYyAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVycy9z Y3NpL2xwZmMvbHBmY19hdHRyLmMgICAgICAgIHwgNDMgKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvdGhlcm1hbC90aGVybWFsX3N5c2ZzLmMgICAgICB8ICA5 ICsrKystLS0tCj4gIGRyaXZlcnMvdHR5L3NlcmlhbC9zaC1zY2kuYyAgICAgICAgICB8ICAyICst Cj4gIGRyaXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYyAgICAgICB8ICAyICstCj4gIGRyaXZl cnMvdXNiL3BoeS9waHktdGFodm8uYyAgICAgICAgICB8ICAyICstCj4gIGRyaXZlcnMvdmlkZW8v ZmJkZXYvYXVvX2sxOTB4LmMgICAgICB8ICA0ICsrLS0KPiAgZHJpdmVycy92aWRlby9mYmRldi93 MTAwZmIuYyAgICAgICAgIHwgIDQgKystLQo+ICBsaWIvdGVzdF9maXJtd2FyZS5jICAgICAgICAg ICAgICAgICAgfCAxNCArKysrKy0tLS0tLS0KPiAgbGliL3Rlc3Rfa21vZC5jICAgICAgICAgICAg ICAgICAgICAgIHwgMTQgKysrKystLS0tLS0tCj4gIHNvdW5kL3NvYy9vbWFwL21jYnNwLmMgICAg ICAgICAgICAgICB8ICA0ICsrLS0KPiAgMTUgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygr KSwgODAgZGVsZXRpb25zKC0pCgpGb3IgZmJkZXYgY2hhbmdlczoKCkFja2VkLWJ5OiBCYXJ0bG9t aWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+CgpCZXN0IHJlZ2Fy ZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdpY3oKU2Ftc3VuZyBSJkQgSW5zdGl0dXRlIFBv bGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 03 Jan 2018 15:16:08 +0000 Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Message-Id: <4624388.pPJCIclP0U@amdc3058> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: linux-fbdev@vger.kernel.org, David Airlie , Heiko Carstens , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Jaroslav Kysela , Peter Ujfalusi , linux-s390@vger.kernel.org, linux-omap@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Takashi Iwai , Sebastian Ott , James Smart , Cezary Jackiewicz , linux-serial@vger.kernel.org, Jiri Slaby , Darren Hart , Zhang Rui , Dick Kennedy , Mathias Nyman , linux-pm@vger.kernel.org, Peter Oberparleiter , intel-gfx@lists.freedesktop.org, Eduardo Valentin On Tuesday, December 19, 2017 10:15:07 AM Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g; print;}' > > Signed-off-by: Joe Perches > --- > arch/s390/kernel/topology.c | 3 +-- > arch/tile/kernel/sysfs.c | 2 +- > drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- > drivers/platform/x86/compal-laptop.c | 18 +++++---------- > drivers/s390/cio/device.c | 2 +- > drivers/scsi/lpfc/lpfc_attr.c | 43 ++++++++++++------------------------ > drivers/thermal/thermal_sysfs.c | 9 ++++---- > drivers/tty/serial/sh-sci.c | 2 +- > drivers/usb/host/xhci-dbgcap.c | 2 +- > drivers/usb/phy/phy-tahvo.c | 2 +- > drivers/video/fbdev/auo_k190x.c | 4 ++-- > drivers/video/fbdev/w100fb.c | 4 ++-- > lib/test_firmware.c | 14 +++++------- > lib/test_kmod.c | 14 +++++------- > sound/soc/omap/mcbsp.c | 4 ++-- > 15 files changed, 49 insertions(+), 80 deletions(-) For fbdev changes: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next,2/4] treewide: Use DEVICE_ATTR_RW From: Bartlomiej Zolnierkiewicz Message-Id: <4624388.pPJCIclP0U@amdc3058> Date: Wed, 03 Jan 2018 16:16:08 +0100 To: Joe Perches Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Cezary Jackiewicz , Darren Hart , Andy Shevchenko , Sebastian Ott , Peter Oberparleiter , James Smart , Dick Kennedy , Zhang Rui , Eduardo Valentin , Greg Kroah-Hartman , Mathias Nyman , Felipe Balbi , "Luis R. Rodriguez" , Peter Ujfalusi , Jarkko Nikula , Martin Schwidefsky , Heiko Carstens , David Airlie , "James E.J. Bottomley" , "Martin K. Petersen" , Jiri Slaby , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org List-ID: T24gVHVlc2RheSwgRGVjZW1iZXIgMTksIDIwMTcgMTA6MTU6MDcgQU0gSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gQ29udmVydCBERVZJQ0VfQVRUUiB1c2VzIHRvIERFVklDRV9BVFRSX1JXIHdoZXJlIHBv c3NpYmxlLgo+IAo+IERvbmUgd2l0aCBwZXJsIHNjcmlwdDoKPiAKPiAkIGdpdCBncmVwIC13IC0t bmFtZS1vbmx5IERFVklDRV9BVFRSIHwgXAo+ICAgeGFyZ3MgcGVybCAtaSAtZSAnbG9jYWwgJC87 IHdoaWxlICg8PikgeyBzL1xiREVWSUNFX0FUVFJccypcKFxzKihcdyspXHMqLFxzKlwoPyhccypT X0lSVUdPXHMqXHxccypTX0lXVVNSfFxzKlNfSVdVU1JccypcfFxzKlNfSVJVR09ccyp8XHMqMDY0 NFxzKilcKT9ccyosXHMqXDFfc2hvd1xzKixccypcMV9zdG9yZVxzKlwpL0RFVklDRV9BVFRSX1JX KFwxKS9nOyBwcmludDt9Jwo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvZSBQZXJjaGVzIDxqb2VAcGVy Y2hlcy5jb20+Cj4gLS0tCj4gIGFyY2gvczM5MC9rZXJuZWwvdG9wb2xvZ3kuYyAgICAgICAgICB8 ICAzICstLQo+ICBhcmNoL3RpbGUva2VybmVsL3N5c2ZzLmMgICAgICAgICAgICAgfCAgMiArLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMgICAgfCAgNiArKy0tLQo+ICBkcml2 ZXJzL3BsYXRmb3JtL3g4Ni9jb21wYWwtbGFwdG9wLmMgfCAxOCArKysrKy0tLS0tLS0tLS0KPiAg ZHJpdmVycy9zMzkwL2Npby9kZXZpY2UuYyAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVycy9z Y3NpL2xwZmMvbHBmY19hdHRyLmMgICAgICAgIHwgNDMgKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvdGhlcm1hbC90aGVybWFsX3N5c2ZzLmMgICAgICB8ICA5 ICsrKystLS0tCj4gIGRyaXZlcnMvdHR5L3NlcmlhbC9zaC1zY2kuYyAgICAgICAgICB8ICAyICst Cj4gIGRyaXZlcnMvdXNiL2hvc3QveGhjaS1kYmdjYXAuYyAgICAgICB8ICAyICstCj4gIGRyaXZl cnMvdXNiL3BoeS9waHktdGFodm8uYyAgICAgICAgICB8ICAyICstCj4gIGRyaXZlcnMvdmlkZW8v ZmJkZXYvYXVvX2sxOTB4LmMgICAgICB8ICA0ICsrLS0KPiAgZHJpdmVycy92aWRlby9mYmRldi93 MTAwZmIuYyAgICAgICAgIHwgIDQgKystLQo+ICBsaWIvdGVzdF9maXJtd2FyZS5jICAgICAgICAg ICAgICAgICAgfCAxNCArKysrKy0tLS0tLS0KPiAgbGliL3Rlc3Rfa21vZC5jICAgICAgICAgICAg ICAgICAgICAgIHwgMTQgKysrKystLS0tLS0tCj4gIHNvdW5kL3NvYy9vbWFwL21jYnNwLmMgICAg ICAgICAgICAgICB8ICA0ICsrLS0KPiAgMTUgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygr KSwgODAgZGVsZXRpb25zKC0pCgpGb3IgZmJkZXYgY2hhbmdlczoKCkFja2VkLWJ5OiBCYXJ0bG9t aWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+CgpCZXN0IHJlZ2Fy ZHMsCi0tLQpCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6ClNhbXN1bmcgUiZEIEluc3RpdHV0ZSBQ b2xhbmQKU2Ftc3VuZyBFbGVjdHJvbmljcwoKLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxp c3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2Yg YSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5m byBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356AbeACPQU (ORCPT + 1 other); Wed, 3 Jan 2018 10:16:20 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:10565 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbeACPQQ (ORCPT ); Wed, 3 Jan 2018 10:16:16 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20180103151613epoutp0460559fd599c7b08894ed925a2f4f24f0~GVbfqHoFG1290012900epoutp04Q X-AuditID: b6c32a36-3bdff7000000117d-07-5a4cf3bca0c2 Sun-Java-System-SMTP-Warning: Lines longer than SMTP allows found and wrapped. From: Bartlomiej Zolnierkiewicz To: Joe Perches Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Cezary Jackiewicz , Darren Hart , Andy Shevchenko , Sebastian Ott , Peter Oberparleiter , James Smart , Dick Kennedy , Zhang Rui , Eduardo Valentin , Greg Kroah-Hartman , Mathias Nyman , Felipe Balbi , "Luis R. Rodriguez" , Peter Ujfalusi , Jarkko Nikula , Martin Schwidefsky , Heiko Carstens , David Airlie , "James E.J. Bottomley" , "Martin K. Petersen" , Jiri Slaby , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Date: Wed, 03 Jan 2018 16:16:08 +0100 Message-id: <4624388.pPJCIclP0U@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0xTVxzHd+67hM67gvMEE5Z18Q/IxmRZzG9Dl21h281Cts7MTZs97OAG H7SyXhUfISHDlZdAZcJcq9NCU0wpg0BBkApZOygaIQINGCIWsCZCVGQINFnUebmY8N/nfL/f 3+OcHI7UTDIJ3F7TQdFsMuRomRiqPZCU8pZvIUO/eSSUAOWDVwkIDfkJqDrzjIQ+S4SF6qkI A87+Mgqs3akQWpxjoNSxGc6HRmkorGtioO/GDAV2aysBXY55AupHmhD0DdlJcJ8ygT18h4Ir DgJONz8iYClUTEB/xSMaRi6fZcDurKRgofwfBFZHIQllYx0MXK8rZ6HW9SsJ9cGnBBS2nKbh pvUugoLlZRJKLlfSYJuP0tDgu0dCj22UhchUBQMLgxYWrpUGEDQvN6IPk4TmhV8Y4WnwCRJs 4QFG+HvazwidtglWaL2YLNT5ZgihxV3CCJeWJmnhz6tfCZP+VkroOedhhXBZkBDm745TwmP3 KCl0P3Axujh9zNYsMWfvYdH89ge7Y/a09W7KLYk9UhPw0gXonKoUqTjMv4v/qLdTpSiG0/Ad CP97z04oh2WEG5auMC9SRWXu1VQzwk5f24qh4RcRLuzNljmO1+GqGy4kM8O/j08VuZ8zx8Xz r+MJ7zq5luQtsfhWWwOt5NNwaMZDyxmK34R9TT/IsppPwnMttwiZ1/OfY2930Qqr+J14rP0E q2RewdHfblMyk/xruLunmlb4TTzQ9xeSZ2E+yuEej4OU+2M+HV+c2qXcJQ7PBr2sIm/Ew73b FPl3hC/9h5XSVoTdXVZWMdJwIDi02v9l/HDxJK3UqnGxRaNEBHy/0UMp/BGu6pxafcNhhF1O F2VFibY1a9vWrG1bs/YFRLrRq2KuZMwWpdTcd1Ikg1E6ZMpOyTxgbEEr/z55SweqHczwI55D 2lj1zfEMvYY2HJaOGv0Ic6Q2Xv3pvueSOstw9JhoPvCj+VCOKPnRRo7SblDrdOl6DZ9tOCju F8Vc0fzCJThVQgFqNFVvj2Tsjt+1FWZrrnmNj08+i3aGHwSyuvKcb6im/bXm/Ot56d+M+iaO Lz68r5PWzXj0czVo9pOIOJiYEv0sMe+nAUtT/Zezmcfe+/rn6QTuTs6Y5faO/p1f+A3DVWTi hrTjtabzH+dnVhbnf/v9S72O9hP9gflwhUn73VjqkzPjWkraY0hNJs2S4X8hmTyn8wMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTYRTHe97bXofDNzN6UipalGiYGkGnC1EE9lAR1aeSyFa+2MXNuXUz ukim5kSdpmlbF5dmsSxtmpc0pZku06TaMrFsmhZJWI3lpQ9ZrhH47Xf+/9/hfDk87d/ABvKH VEdFjUoRL+ekTMfk4MywBvfW6AiXMQKyutopcLyyUpBX9IeGtrQhCRQMDHFQ+iyTAX1TJDhG v3OgM0XADUc3CyklFRy0vRxmwKivoqDB5KLgtr0CQdsrIw3mXBUYnYMMPDZRkF/5g4Ixx0UK nmX/YMH+6CoHxtIcBtxZTxHoTSk0ZL6t46CzJEsCN8tSabhtm6QgxZLPQo/+E4Lk8XEaMh7l sGBwTbBwt/ELDc2GbgkMDWRz4O5Kk8BzXQuCyvF7aH0IqXSf58ik7TciBucLjjz5aOVIvaFP QqruhJKSxmGKWMwZHKkd62fJ9fYdpN9axZDma+US4sy0UcT1qZchP83dNGkaKeO2z4qWro0V 4w8dFzXh6/ZJDz5sXazO8D15uaWaTUbXfHTIh8fCCpyeaWZ0SMr7C/cR7rpUTHuHUYTzv/xi PdYsYRs+fzWP9jAnrMa56WakQzwfICzEfdV+Hp8W9L646IGT9vprsGO4nPU4jLAYN1bs9cQy IQR/t7ynPDxb2Iyrm9L/sY+wC9/QWyjv3dcIV976LPEuzMQTlz4wHqaFBbipuYD1ciiuqLdR eiQYpmmGaZphmlaMaDOaK6q1yjildrk6UiWeWKZVKLXHVHHLDiQoLWjqpWpaQrPrkLM0xooE Hsl9ZT29W6P9WcVxbZLSijBPywNkUYenIlmsIumUqEmI0RyLF7VWFMQz8jmyd6q23f5CnOKo eEQU1aLmf0vxPoHJaB4b7DbV5hXUFG1pLzUwdtv8JYU9D/u+hq+qqT8z2XqxtlH95v3CeHfh tz+7F31zxUhPBoTP2N8xssI9ELEhsb81TA4oeOnz9Hf37MEhh2Nlp40by1PEvKCE1JyVZ6jR AHtx/c65fok79lwpi5o4u696wlqIe00rSe+5TReWdHY+ljPag4rIUFqjVfwFScvUfk4DAAA= X-CMS-MailID: 20180103151611epcas1p249ad052a59c54ea41d4e80b00aef59e6 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171219181536epcas2p18d023209dc13ac504457c07b8b2b8965 X-RootMTR: 20171219181536epcas2p18d023209dc13ac504457c07b8b2b8965 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tuesday, December 19, 2017 10:15:07 AM Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g; print;}' > > Signed-off-by: Joe Perches > --- > arch/s390/kernel/topology.c | 3 +-- > arch/tile/kernel/sysfs.c | 2 +- > drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- > drivers/platform/x86/compal-laptop.c | 18 +++++---------- > drivers/s390/cio/device.c | 2 +- > drivers/scsi/lpfc/lpfc_attr.c | 43 ++++++++++++------------------------ > drivers/thermal/thermal_sysfs.c | 9 ++++---- > drivers/tty/serial/sh-sci.c | 2 +- > drivers/usb/host/xhci-dbgcap.c | 2 +- > drivers/usb/phy/phy-tahvo.c | 2 +- > drivers/video/fbdev/auo_k190x.c | 4 ++-- > drivers/video/fbdev/w100fb.c | 4 ++-- > lib/test_firmware.c | 14 +++++------- > lib/test_kmod.c | 14 +++++------- > sound/soc/omap/mcbsp.c | 4 ++-- > 15 files changed, 49 insertions(+), 80 deletions(-) For fbdev changes: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics