All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rudolf Marek <r.marek@assembler.cz>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] k8temp - Add the diode offset to reported
Date: Tue, 17 Apr 2007 16:24:57 +0000	[thread overview]
Message-ID: <4624F4D9.20908@assembler.cz> (raw)
In-Reply-To: <1176736441.14094.31.camel@ustr-shaha1-linux2.na.uis.unisys.com>

Hello all,

Amul Shah wrote:
> This patch adds support to include the CPU diode sensor offset when
> reporting CPU temperature.
> 
> Please see http://www.lm-sensors.org/ticket/2200 for the full problem
> description.

Well I dont think this is correct. I believe that diode offset register is
related to analog diode output not the digital sensor. Also I know that AMD is
using my driver and did not make any changes. This leads me to a conclusion that
the sensor simply does not work correctly and this error might be only
compensated for analog part and not the digital. IIRC in some errata AMD states
that the digital temperature sensor might be wrong and urges users to use the
analog output.

What do you think?

Thanks,

Rudolf

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-04-17 16:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16 15:14 [lm-sensors] [PATCH] k8temp - Add the diode offset to reported Amul Shah
2007-04-17 13:49 ` Amul Shah
2007-04-17 16:24 ` Rudolf Marek [this message]
2007-04-19 12:31 ` Jean Delvare
2007-05-17  0:06 ` Philip Pokorny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4624F4D9.20908@assembler.cz \
    --to=r.marek@assembler.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.