Re: [PATCH pata-2.6] cmd64x: procfs code fixes/cleanups (take 2)

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Mark Lord wrote:

>>>>>> - correct the chipset names (from CMDxxx to PCI-xxx)

>>>>> Please explain why this rename is a correction.

>>>>   Because the chips are officially named PCI064[036] and PCI-64[89].

>>> We normally name things with a combination of brand and chip number.
>>> Lots of companies could have chips with PCI in the name,
>>> but the CMD64x designator makes it quite clear what we're dealing 
>>> with here.

>>   Note that I'm only changing designator in the procfs output, i.e. 
>> not something important to end user.

> Err.. in this case, the procfs output *is* there for the end-user.

   Aha, that's why it was removed form the most IDE drivers I guess. :-)

> Using the name printed on the chip, which matches the cmdxxx.c driver name,
> is by far the least confusing way to do it here.

   And I'm using the name printed on the chip.

>>> In the machines I have here with these chips,
>>> they are clearly labelled as "CMD" and then "PCI646.."

>>   Although I've never seen the chip, I guess that should be logo, not 
>> the name.

> Then perhaps you should test the scheme against the real hardware
> before patching it.

   LOL. There's thing called remote testing -- I guess you never bothered to look at the patches themselves.

> Cheers

MBR, Sergei