From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 05/13] udmabuf: constify udmabuf_create args Date: Tue, 11 Sep 2018 17:53:06 +0300 Message-ID: <4625619.OKDULqJxva@avalon> References: <20180911134216.9760-1-kraxel@redhat.com> <20180911134216.9760-6-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB81B6E3A9 for ; Tue, 11 Sep 2018 14:52:56 +0000 (UTC) In-Reply-To: <20180911134216.9760-6-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: open list , dri-devel@lists.freedesktop.org, "moderated list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" List-Id: dri-devel@lists.freedesktop.org SGkgR2VyZCwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlc2RheSwgMTEgU2VwdGVt YmVyIDIwMTggMTY6NDI6MDggRUVTVCBHZXJkIEhvZmZtYW5uIHdyb3RlOgo+IFJlcG9ydGVkLWJ5 OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+Cj4gUmV2aWV3 ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNv bT4KPiBBY2tlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAt LS0KPiAgZHJpdmVycy9kbWEtYnVmL3VkbWFidWYuYyB8IDQgKystLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2RtYS1idWYvdWRtYWJ1Zi5jIGIvZHJpdmVycy9kbWEtYnVmL3VkbWFidWYuYwo+IGluZGV4 IGUzNTYwZTg0MGQuLjQxNjdkYTgxNDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL3Vk bWFidWYuYwo+ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi91ZG1hYnVmLmMKPiBAQCAtMTE2LDggKzEx Niw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX2J1Zl9vcHMgdWRtYWJ1Zl9vcHMgPSB7Cj4g ICNkZWZpbmUgU0VBTFNfV0FOVEVEIChGX1NFQUxfU0hSSU5LKQo+ICAjZGVmaW5lIFNFQUxTX0RF TklFRCAoRl9TRUFMX1dSSVRFKQo+IAo+IC1zdGF0aWMgbG9uZyB1ZG1hYnVmX2NyZWF0ZShzdHJ1 Y3QgdWRtYWJ1Zl9jcmVhdGVfbGlzdCAqaGVhZCwKPiAtCQkJICAgc3RydWN0IHVkbWFidWZfY3Jl YXRlX2l0ZW0gKmxpc3QpCj4gK3N0YXRpYyBsb25nIHVkbWFidWZfY3JlYXRlKGNvbnN0IHN0cnVj dCB1ZG1hYnVmX2NyZWF0ZV9saXN0ICpoZWFkLAo+ICsJCQkgICBjb25zdCBjb25zdCBzdHJ1Y3Qg dWRtYWJ1Zl9jcmVhdGVfaXRlbSAqbGlzdCkKCkV2ZW4gaWYgeW91IHJlYWxseSB3YW50IHRvIG1h a2UgaXQgY29uc3QsIGEgc2luZ2xlIGNvbnN0IHNob3VsZCBzdWZmaWNlIDotKQoKPiAgewo+ICAJ REVGSU5FX0RNQV9CVUZfRVhQT1JUX0lORk8oZXhwX2luZm8pOwo+ICAJc3RydWN0IGZpbGUgKm1l bWZkID0gTlVMTDsKCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:38930 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbeIKTwf (ORCPT ); Tue, 11 Sep 2018 15:52:35 -0400 From: Laurent Pinchart To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, Sumit Semwal , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list Subject: Re: [PATCH v2 05/13] udmabuf: constify udmabuf_create args Date: Tue, 11 Sep 2018 17:53:06 +0300 Message-ID: <4625619.OKDULqJxva@avalon> In-Reply-To: <20180911134216.9760-6-kraxel@redhat.com> References: <20180911134216.9760-1-kraxel@redhat.com> <20180911134216.9760-6-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Gerd, Thank you for the patch. On Tuesday, 11 September 2018 16:42:08 EEST Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart > Signed-off-by: Gerd Hoffmann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel Vetter > --- > drivers/dma-buf/udmabuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index e3560e840d..4167da8141 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -116,8 +116,8 @@ static const struct dma_buf_ops udmabuf_ops = { > #define SEALS_WANTED (F_SEAL_SHRINK) > #define SEALS_DENIED (F_SEAL_WRITE) > > -static long udmabuf_create(struct udmabuf_create_list *head, > - struct udmabuf_create_item *list) > +static long udmabuf_create(const struct udmabuf_create_list *head, > + const const struct udmabuf_create_item *list) Even if you really want to make it const, a single const should suffice :-) > { > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > struct file *memfd = NULL; -- Regards, Laurent Pinchart