From: Patrick McHardy <kaber@trash.net>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Pavel Emelianov <xemul@sw.ru>, David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org, Kirill Korotaev <dev@openvz.org>
Subject: Re: [NETLINK] Don't attach callback to a going-away netlink socket
Date: Wed, 18 Apr 2007 11:16:50 +0200 [thread overview]
Message-ID: <4625E202.8040604@trash.net> (raw)
In-Reply-To: <20070418090720.GA25070@2ka.mipt.ru>
Evgeniy Polyakov wrote:
> On Wed, Apr 18, 2007 at 10:50:42AM +0200, Patrick McHardy (kaber@trash.net) wrote:
>
>>>I thought that with releasing a socket, which will have a callback
>>>attached only results in a leak of the callback? In that case we can
>>>just free it in dump() just like it is done in no-error path already.
>>>Or do I miss something additional?
>>
>>That would only work if there is nothing to dump (cb->dump returns 0).
>>Otherwise it is not freed.
>
>
> That is what I referred to as error path. Btw, with positive return
> value we end up in subsequent call to input which will free callback
> under lock as expected.
No, nothing is going to call netlink_dump after the initial call since
the socket is gone.
next prev parent reply other threads:[~2007-04-18 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 8:16 [NETLINK] Don't attach callback to a going-away netlink socket Pavel Emelianov
2007-04-18 8:17 ` Evgeniy Polyakov
2007-04-18 8:26 ` Patrick McHardy
2007-04-18 8:42 ` Evgeniy Polyakov
2007-04-18 8:50 ` Patrick McHardy
2007-04-18 9:07 ` Evgeniy Polyakov
2007-04-18 9:16 ` Patrick McHardy [this message]
2007-04-18 9:29 ` Evgeniy Polyakov
2007-04-18 8:32 ` Pavel Emelianov
2007-04-18 8:44 ` Evgeniy Polyakov
2007-04-18 9:03 ` Pavel Emelianov
2007-04-18 9:14 ` Evgeniy Polyakov
2007-04-19 0:06 ` David Miller
2007-04-19 2:13 ` Herbert Xu
2007-04-29 6:18 ` David Miller
2007-05-02 4:12 ` Herbert Xu
2007-05-03 10:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4625E202.8040604@trash.net \
--to=kaber@trash.net \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.