From: Johannes Sixt <J.Sixt@eudaptics.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Custom low-level merge driver support.
Date: Wed, 18 Apr 2007 12:36:29 +0200 [thread overview]
Message-ID: <4625F4AD.5CDDC502@eudaptics.com> (raw)
In-Reply-To: 1176888062865-git-send-email-junkio@cox.net
Junio C Hamano wrote:
> + interpolate(cmdbuf, sizeof(cmdbuf), cmd, table, 3);
> +
> + memset(&child, 0, sizeof(child));
> + child.argv = args;
> + args[0] = "sh";
> + args[1] = "-c";
> + args[2] = cmdbuf;
> + args[3] = NULL;
If I read the code correctly, there does not happen any shell quoting
anywhere; hence, this shell invocation is dangerous.
-- Hannes
next prev parent reply other threads:[~2007-04-18 10:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 9:21 [PATCH 0/2] Custom low-level merge driver support Junio C Hamano
2007-04-18 9:21 ` [PATCH 1/2] " Junio C Hamano
2007-04-18 10:36 ` Johannes Sixt [this message]
2007-04-18 10:55 ` Johannes Schindelin
2007-04-18 9:21 ` [PATCH 2/2] Allow the default low-level merge driver to be configured Junio C Hamano
2007-04-18 10:48 ` [PATCH 0/2] Custom low-level merge driver support Johannes Schindelin
2007-04-18 15:34 ` Martin Waitz
2007-04-18 15:56 ` Junio C Hamano
2007-04-18 16:08 ` Martin Waitz
2007-04-18 16:16 ` Linus Torvalds
2007-04-18 17:10 ` Junio C Hamano
2007-04-18 18:45 ` Linus Torvalds
2007-04-18 19:00 ` Junio C Hamano
2007-04-18 19:23 ` Junio C Hamano
2007-04-18 19:43 ` Linus Torvalds
2007-04-18 19:51 ` Linus Torvalds
2007-04-18 20:13 ` Junio C Hamano
2007-04-18 20:35 ` Linus Torvalds
2007-04-18 20:09 ` David Lang
2007-04-18 21:01 ` Junio C Hamano
2007-04-19 7:52 ` Martin Waitz
2007-04-19 8:08 ` Junio C Hamano
2007-04-18 18:28 ` [PATCH] Custom low-level merge driver: change the configuration scheme Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4625F4AD.5CDDC502@eudaptics.com \
--to=j.sixt@eudaptics.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.