From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754287AbXDSWv6 (ORCPT ); Thu, 19 Apr 2007 18:51:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754290AbXDSWv6 (ORCPT ); Thu, 19 Apr 2007 18:51:58 -0400 Received: from ug-out-1314.google.com ([66.249.92.174]:21832 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754287AbXDSWv5 (ORCPT ); Thu, 19 Apr 2007 18:51:57 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=sKRSHz0ehXFnzZ78QejLzU+Zy+RsVUdx+LjxTeUCp11qC5N3Lb4ZJqPyl4S39NuywcbvVoQzcGsxBBVRBc+pDeaEwaSND+WUr8fBH/Dkyr1oUB494zW6S+xgEnfZVkteKaRu/r02r+0HQ8a4B0/ovW+SHygGYL+uTsxPDvIJ418= Message-ID: <4627F283.6030009@gmail.com> Date: Fri, 20 Apr 2007 02:51:47 +0400 From: Manu Abraham User-Agent: Thunderbird 1.5.0.10 (X11/20070306) MIME-Version: 1.0 To: Markus Rechberger CC: hermann pitton , Michael Krufky , linux-dvb@linuxtv.org, linux-kernel@vger.kernel.org Subject: Re: [linux-dvb] Re: [video4linux-cvs] [hg:v4l-dvb] Add support for Opera S1- DVB-USB References: <4627858A.6060209@linuxtv.org> <4627B959.8070601@freenet.de> <4627D407.10105@linuxtv.org> <1177015513.6002.40.camel@matwk009568.brasiltelecom.intra.corp> <4627D74A.4090304@gmail.com> <1177019927.3166.8.camel@pc06.localdom.local> <4627F076.4050105@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Markus Rechberger wrote: > On 4/20/07, Manu Abraham wrote: >> hermann pitton wrote: >> > Am Freitag, den 20.04.2007, 00:55 +0400 schrieb Manu Abraham: >> >> Mauro Carvalho Chehab wrote: >> >>> Em Qui, 2007-04-19 ās 16:41 -0400, Michael Krufky escreveu: >> >>>> Marco Gittler wrote: >> >>>>> this patch has applied the hints from mkrufky (dvb_attach, >> >>>>> firmware-naming) >> >>>>> and also one working rewrite of the i2c addresses stuff to fit the >> >>>>> kernel i2c reqs. >> >>>>> >> >>>>> Signed-off-by: Marco Gittler >> >>>>> diff -r c8b73ec18b42 linux/drivers/media/dvb/dvb-usb/opera1.c >> >>>>> --- a/linux/drivers/media/dvb/dvb-usb/opera1.c Thu Apr 19 >> 12:04:50 >> 2007 -0300 >> >>>>> +++ b/linux/drivers/media/dvb/dvb-usb/opera1.c Thu Apr 19 >> 20:38:01 >> 2007 +0200 >> >>>>> @@ -25,6 +25,13 @@ >> >>>>> #define REG_20_SYMBOLRATE_BYTE1 0x20 >> >>>>> #define REG_21_SYMBOLRATE_BYTE2 0x21 >> >>>>> >> >>>>> +#define ADDR_C0_TUNER (0xc0>>1) >> >>>>> +#define ADDR_D0_PLL (0xd0>>1) >> >>>>> >> >>>> I don't like these two #define's. These i2c addresses need only be >> >>>> specified once, in the config structs / frontendfoo_attach calls for >> the >> >>>> tuner / demod. >> >>>> >> >>>> Better to just put them in as constants like all of the other dvb >> drivers. >> >>> I prefer the way it is. We should really avoid having magic numbers >> >>> inside the code. The alias here helps to know that 0x60 is tuner >> addres >> >>> and 0x68 the pll. >> >> >> >> Following a project's coding styles and conventions is "respecting" a >> >> project >> >> >> >> Manu >> >> >> > >> > Hi, >> > >> > the other natural place for this should be the LKML to get more _good_ >> > arguments, instead of hanging soon in some "respect" stuff again. >> >> >> DVB drivers generally have device addresses such as tuner_addresses and >> demod_adresses defined in a config struct least to prevent them from >> being global, wherever the header is included, since the very same >> device can have multiple addresses and so on, which are non-probable >> since being behind a repeater which is switched by a demod (private) and >> hence. >> >> Those are some of the reasons to follow a certain coding >> style/conventions. They are _not_ for fun. >> > > cat *priv.h says something else too... > there are also many global register defines in DVB drivers, they just > don't include the register value in the define name. *_priv.h from what i understand means private .. i don't know what you make out from that. HTH, Manu