All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, venza@brownhat.org
Subject: Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation
Date: Fri, 20 Apr 2007 11:41:45 -0400	[thread overview]
Message-ID: <4628DF39.8020305@garzik.org> (raw)
In-Reply-To: <20070420135458.GB16191@hmsreliant.homelinux.net>

Neil Horman wrote:
> Hey there-
> 	The sis900 driver appears to have a bug in which the receive routine
> passes the skbuff holding the received frame to the network stack before
> refilling the buffer in the rx ring.  If a new skbuff cannot be allocated, the
> driver simply leaves a hole in the rx ring, which causes the driver to stop
> receiving frames and become non-recoverable without an rmmod/insmod according to
> reporters.  This patch reverses that order, attempting to allocate a replacement
> buffer first, and receiving the new frame only if one can be allocated.  If no
> skbuff can be allocated, the current skbuf in the rx ring is recycled, dropping
> the current frame, but keeping the NIC operational.
> 
> Thanks & Regards
> Neil
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

Please CC the net driver maintainer ;-)

I'll queue this for review.



  reply	other threads:[~2007-04-20 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-20 13:54 [PATCH] sis900: Allocate rx replacement buffer before rx operation Neil Horman
2007-04-20 15:41 ` Jeff Garzik [this message]
2007-04-20 17:55 ` Daniele Venzano
2007-04-24 16:43 ` Jeff Garzik
2007-04-26 17:47   ` Neil Horman
2007-04-26 23:30     ` Neil Horman
2007-04-28  0:17     ` Jeff Garzik
2007-04-28 22:24       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4628DF39.8020305@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=venza@brownhat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.