Re: [PATCH] creating link /dev/root to device / is mounted from

[Doug Goldstein <cardoe@gentoo.org>]

[-- Attachment #1.1.1: Type: text/plain, Size: 754 bytes --]

I honestly feel that this is a kernel issue. Since according to the
mount man page, /proc/mounts and /etc/mtab should be relatively in sync
and /etc/mtab can technically be a symlink of /proc/mounts. It states
that /proc/mounts should update quicker and as such should technically
be more reliable. Which I feel contradicts some people's opinions that
the kernel and /proc/mounts can not be trusted. I think this is bogus
because with an initramfs, the kernel does the right thing. Without one,
it hardcodes itself to /dev/root when the kernel knows via the root=
option what the proper dev node should be.

As a result, here's a kernel patch to correct this issue.


-- 
Doug Goldstein <cardoe@gentoo.org>
http://dev.gentoo.org/~cardoe/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: dev-root-real-root.patch --]
[-- Type: text/x-patch; name="dev-root-real-root.patch", Size: 913 bytes --]

--- linux-2.6.20-gentoo-r6/init/do_mounts.c	2007-04-17 01:27:27.000000000 -0400
+++ linux-dev-root/init/do_mounts.c	2007-04-21 13:00:32.000000000 -0400
@@ -354,7 +354,10 @@
 	va_start(args, fmt);
 	vsprintf(buf, fmt, args);
 	va_end(args);
-	fd = sys_open("/dev/root", O_RDWR | O_NDELAY, 0);
+	if (saved_root_name[0])
+		fd = sys_open(saved_root_name, O_RDWR | O_NDELAY, 0);
+	else
+		fd = sys_open("/dev/root", O_RDWR | O_NDELAY, 0);
 	if (fd >= 0) {
 		sys_ioctl(fd, FDEJECT, 0);
 		sys_close(fd);
@@ -397,8 +400,13 @@
 	}
 #endif
 #ifdef CONFIG_BLOCK
-	create_dev("/dev/root", ROOT_DEV);
-	mount_block_root("/dev/root", root_mountflags);
+	if (saved_root_name[0]) {
+		create_dev(saved_root_name, ROOT_DEV);
+		mount_block_root(saved_root_name, root_mountflags);
+	} else {
+		create_dev("/dev/root", ROOT_DEV);
+		mount_block_root("/dev/root", root_mountflags);
+	}
 #endif
 }
 

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #3: Type: text/plain, Size: 226 bytes --]

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel