From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Caulfield Date: Mon, 23 Apr 2007 11:19:52 +0100 Subject: [Cluster-devel] [DLM][PATCH] lowcomms init fixes In-Reply-To: <20070420225100.GE22226@korben.rdu.redhat.com> References: <20070420202550.GC22226@korben.rdu.redhat.com> <20070420225100.GE22226@korben.rdu.redhat.com> Message-ID: <462C8848.7060102@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Thanks for finding & fixing those bugs Josef. I've changed the patch a little, making the comparison always <= max_nodeid, I prefer max_modeid to be what it says it as and not 1 more than the max node ID. I'm a little concerned about the need for idr_init() in lowcomms_close(). Surely if the idr was properly cleaned out it would not be necessary - though somehow it seems to be, Do you know what's actually happening here ? Anyway, here's the modified patch. it seems to work for me, but I'd be grateful if you could run it through your tests too, cos I'm supposed to be working on something else@the moment! Steve, can you wait till Josef has tested this patch before adding it to the git tree? thanks. -- Patrick Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 ITE, UK. Registered in England and Wales under Company Registration No. 3798903 -------------- next part -------------- A non-text attachment was scrubbed... Name: lowcomms-fix.patch Type: text/x-patch Size: 2509 bytes Desc: not available URL: