From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] sl82c105: Switch to ref counting API
Date: Mon, 23 Apr 2007 18:04:02 +0400 [thread overview]
Message-ID: <462CBCD2.3080302@ru.mvista.com> (raw)
In-Reply-To: <20070423145445.45f5dc6a@the-village.bc.nu>
Hello.
Alan Cox wrote:
> Not sure how this one got missed in the great purge some time ago but it
> did.
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c linux-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c
> --- linux.vanilla-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c 2007-04-12 14:15:04.000000000 +0100
> +++ linux-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c 2007-04-23 11:58:55.016516864 +0100
> @@ -349,7 +349,7 @@
> /*
> * The bridge should be part of the same device, but function 0.
> */
> - bridge = pci_find_slot(dev->bus->number,
> + bridge = pci_get_bus_and_slot(dev->bus->number,
> PCI_DEVFN(PCI_SLOT(dev->devfn), 0));
Isn't it better to use pci_get_slot()?
WBR, Sergei
prev parent reply other threads:[~2007-04-23 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 13:54 [PATCH] sl82c105: Switch to ref counting API Alan Cox
2007-04-23 14:04 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462CBCD2.3080302@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.