All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Ian Campbell <Ian.Campbell@XenSource.com>,
	Keir Fraser <keir@XenSource.com>
Cc: xen-devel@lists.xensource.com
Subject: trap bounce flags
Date: Wed, 25 Apr 2007 10:56:36 +0100	[thread overview]
Message-ID: <462F41F4.76E4.0078.0@novell.com> (raw)

With the severe stability issues we are having with SLE10sp1 on x86-64, things
start pointing pretty closely at the int80 direct trap patch we imported from
-unstable. While I just now realized that there's been a fix for these problems
for quite a while (don't know how this slipped my attention), I still have a few
notes:

- even compat_restore_all_guest now asserts interrupts are disabled, despite
  32-bit restore_all_guest not doing so (and the iret path not generally needing
  this)
- int80_direct_trap checks for non-zero TRAPBOUNCE_flags, yet
  {,compat_}create_bounce_frame clear the low byte of these flags (i.e.
  including TBF_exception, which is in this lower byte); it appears to be only a
  lucky coincidence that this still works as the cmp (again!) is suffix-less and
  hence gets sized as a 32-bit compare, accidentally covering TRAPBOUNCE_cs
- from the above, why is it that only the lower byte (if anything) needs clearing?

Jan

             reply	other threads:[~2007-04-25  9:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25  9:56 Jan Beulich [this message]
2007-04-25 10:10 ` trap bounce flags Keir Fraser
2007-04-25 10:16   ` Keir Fraser
2007-04-25 10:33   ` Jan Beulich
2007-04-25 10:41     ` Keir Fraser
2007-04-25 10:56       ` Keir Fraser
2007-04-25 11:11         ` Jan Beulich
2007-04-25 11:26           ` Keir Fraser
2007-04-25 11:48             ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462F41F4.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Ian.Campbell@XenSource.com \
    --cc=keir@XenSource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.