From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: trap bounce flags
Date: Wed, 25 Apr 2007 12:48:17 +0100
Message-ID: <462F5C21.76E4.0078.0@novell.com>
References: <462F5365.76E4.0078.0@novell.com>
	<C254F960.DD1E%keir@xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C254F960.DD1E%keir@xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>> And my patch has a not directly related adjustment removing the
>>=20
>>         movl  $TRAP_syscall,UREGS_entry_vector+8(%rsp)
>>=20
>> close to the end of compat_create_bounce_frame, as this is meaningless
>> here.
>
>Should we also remove it from compat_hypercall?

Probably not, to be able to identify the frame properly in case something
crashes in the process of handling the hypercall.

Jan