All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Ebbert <cebbert@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	Sergey Vlasov <vsu@altlinux.ru>
Subject: Re: IPV6 source routing patch is still broken?
Date: Thu, 26 Apr 2007 18:57:06 -0400	[thread overview]
Message-ID: <46312E42.4070204@redhat.com> (raw)
In-Reply-To: <20070426.153142.57441302.davem@davemloft.net>

David Miller wrote:
>> +       case IPV6_SRCRT_TYPE_2:
>> +               if (accept_source_route >= 0)
>> +                       break;
>> +               kfree_skb(skb);
>> +               return -1;
>> +       case IPV6_SRCRT_TYPE_0:
>> +               if (accept_source_route > 0)
>> +                       break;
>> +               kfree_skb(skb);
>> +               return -1;
> 
> Yes, that looks like it matches the sysctl documentation more closely:
> 
> accept_source_route - INTEGER
> 	Accept source routing (routing extension header).
> 
> 	> 0: Accept routing header.
> 	= 0: Accept only routing header type 2.
> 	< 0: Do not accept routing header.
> 
> Type 2 packets should get through as long as the value of the sysctl
> is not negative.

It was Sergey Vlasov who first found this. I had tried to find his original
message but I was searching the wrong place.

Sergey, you should send networking-related messages to netdev.


  reply	other threads:[~2007-04-26 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 21:53 IPV6 source routing patch is still broken? Chuck Ebbert
2007-04-26 22:04 ` David Miller
2007-04-26 23:10   ` Chuck Ebbert
2007-04-26 23:52     ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-27  2:29     ` David Miller
2007-04-26 22:31 ` David Miller
2007-04-26 22:57   ` Chuck Ebbert [this message]
2007-04-27  9:08     ` David Miller
2007-04-27  9:36       ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-27  9:41         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46312E42.4070204@redhat.com \
    --to=cebbert@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=vsu@altlinux.ru \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.