From: Eric Sandeen <sandeen@sandeen.net>
To: nscott@aconex.com
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] make growfs check device size limits too
Date: Thu, 26 Apr 2007 21:24:00 -0500 [thread overview]
Message-ID: <46315EC0.9080401@sandeen.net> (raw)
In-Reply-To: <1177631120.6273.380.camel@edge>
Nathan Scott wrote:
> On Thu, 2007-04-26 at 08:10 +0100, Christoph Hellwig wrote:
>> On Thu, Apr 26, 2007 at 04:30:14PM +1000, Nathan Scott wrote:
>>> On the mount path we check for a superblock that describes a filesystem
>>> to large for the running kernel to handle. This catches the case of an
>>> attempt to mount a >16TB filesystem on i386 (where we are limited by the
>>> page->index size, for XFS metadata buffers in xfs_buf.c).
>>>
>>> This patch makes similar checks on the growfs code paths for regular and
>>> realtime growth, else we can end up with filesystem corruption, it would
>>> seem (from #xfs chatter). Untested patch follows; probably better to do
>>> this as a macro, in a header, and call that in each place...?
>> Yeah, the check should probably we in one place only. Given that's it's
>> only used in slow pathes a function would probably do it.
>
> Here's a revised version...
>
> cheers.
>
Looks good to me
-Eric
next prev parent reply other threads:[~2007-04-27 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 6:30 [PATCH] make growfs check device size limits too Nathan Scott
2007-04-26 7:10 ` Christoph Hellwig
2007-04-26 23:45 ` Nathan Scott
2007-04-27 2:24 ` Eric Sandeen [this message]
2007-04-27 6:16 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46315EC0.9080401@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.