Re: [Adeos-main] [PATCH 5/7] Introduce ipipe_base.h (i386/x86_64)

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Dmitry Adamushko wrote:
> On 26/04/07, Jan Kiszka <jan.kiszka@domain.hid> wrote:
>> These patches introduce minimalistic ipipe_base.h to be included by
>> every header out there in the kernel without any dependencies. That is
>> exploited here to move all *stall_root() related prototypes out off
>> irqflags.h, to following patches need ipipe_base.h as well.
> 
> So this file is supposed to extend with another generic stuff, isn't
> it? At the moment it's completely about the root domain, so one would
> think of ipipe_root.h as a more appropriate name.

Yes, when just looking at this particular patch. But then patch #7
extends the scope.

> 
> And this "minimalistic" and "without any dependencies" is due to the
> heaviness of linux/pipe.h?

Yep. Originally, I tried hard to drag central parts of struct
ipipe_domain into it. The goal was to work on a known root domain
structure instead of poking half-blind into it for the domain state. But
I already failed due to struct list_entry and IPIPE_NR_IRQS (would have
required something like asm/ipipe_base.h :-/). Not to speak of struct mutex.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]