From: Corey Minyard <minyard@acm.org>
To: Corey Minyard <minyard@acm.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-serial@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] serial 8250: move push calls out of lock
Date: Fri, 27 Apr 2007 08:09:23 -0500 [thread overview]
Message-ID: <4631F603.40901@acm.org> (raw)
In-Reply-To: <46311E48.4070106@acm.org>
Corey Minyard wrote:
> Russell King wrote:
>>
>> Use of an uninitialised variable. The reason we use check_modem_status
>> to return the current status here is because reading the MSR _clears_
>> interrupts. So, repeatedly calling get_mctrl via an ioctl is a great
>> way to introduce a hardware race condition if you just read the MSR and
>> never act on it.
>>
> "status" is used as a return variable; it is set by the call. I modified
> check_modem_status() to return if it detected a change and set the
> status if it was passed in.
Ok, I see what I missed. Never mind.
-corey
prev parent reply other threads:[~2007-04-27 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 20:51 [PATCH] serial 8250: move push calls out of lock Corey Minyard
2007-04-26 20:58 ` Russell King
2007-04-26 21:48 ` Corey Minyard
2007-04-27 13:09 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4631F603.40901@acm.org \
--to=minyard@acm.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.