From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Massimo Di Nitto Date: Fri, 27 Apr 2007 15:15:46 +0200 Subject: [Cluster-devel] [PATCH] cleanup build system a bit. In-Reply-To: <4631F228.3090906@redhat.com> References: <462DFE84.2080605@ubuntu.com> <462FC46A.70405@redhat.com> <463019C3.8090302@ubuntu.com> <4631F228.3090906@redhat.com> Message-ID: <4631F782.3050509@ubuntu.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Robert Peterson wrote: > Fabio Massimo Di Nitto wrote: >>> I think this patch is something that we can commit to the -HEAD branch and start >>> using for FC8 and beyond. We shouldn't have a problem patching up any minor >>> issues that crop up. I vote for committing this patch. > > Hi Fabio, > > This looks like a good patch to me. I've been too busy to look at it in > any great detail, but I did look at the highlights. great thanks. > I have a minor concern > about the Makefile in gfs2/mkfs: IIRC, it looked like the default "Make" > (all) specified only mkfs.gfs2 as the target, whereas we need to be sure to > that gfs2_jadd and gfs2_grow get built as well. Right.. patch in attachment to turn the Makefile in line with the others. > Er, well, I guess you don't > have gfs2_grow yet (but I do). well i can't really cope with stuff that's not in CVS yet :))) really.. even when i try hard ;) > Maybe it's already assured with some magic > and trickery, as it often happens in many Makefiles, but that will be apparent > soon enough if/when I get a chance to try it. Once you commit gfs2_grow in CVS HEAD, i can add it to the Makefile. > As with any change with so many things affected, there might be some minor > glitches or gotchas that we'll find, but I think we can work around those > as we encounter them. I got a CVS access, so i can fix most of them once they are reported tho I was asked to always ask for patch review before applying, so it's just a matter for somebody to ACK. > Good job! Thanks Fabio PS I plan to commit sometime on monday EU time. If you can add gfs2_grow i will merge the Makefiles at the same time. -- I'm going to make him an offer he can't refuse. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 010_gfs2_mkfs_cleanup.dpatch URL: