From: James Ketrenos <jketreno@linux.intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: Dan Williams <dcbw@redhat.com>,
Michael Wu <flamingice@sourmilk.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 09/13] mac80211: remove hw_scan callback
Date: Fri, 27 Apr 2007 10:02:33 -0700 [thread overview]
Message-ID: <46322CA9.7090606@linux.intel.com> (raw)
In-Reply-To: <20070427172004.32b7bf4a@griffin.suse.cz>
Jiri Benc wrote:
> The problem is that Michael during fixing of the stack for mainline
> inclusion encountered a problem with the current implementation of the
> hw scanning. We need to fix that problem.
All his patch does is delete the hw_scan callback. It doesn't *fix* anything.
> The proposed solution (removing of the hw_scan callback) obviously
> fixes the problem.
No, it doesn't fix the problem--it removes the functionality. Deleting automatic AP selection "fixes the problem" too.
> Now, let's find something that fixes the problem as
> well but doesn't remove the functionality. James already proposed a
> solution that could work if a support for user space MLME is added. Do
> you have an idea how to add it?
userspace MLME needs to have a scan command if you really want to have efficient scanning controlled by userspace. Tuning, waiting, tuning, waiting, tx, listening, tuning, ... introduces a *lot* of userspace/kernel/hardware bouncing.
The userspace MLME can evolve over time.
User space can try and do sw scanning even if the hw_scan callback is setup. Nothing about adding hw_scan prevents userspace from thrashing between the kernel, the drivers, and the host to chew up extra CPU cycles.
James
next prev parent reply other threads:[~2007-04-27 17:22 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 18:48 [PATCH 01/13] mac80211: Add radiotap support Michael Wu
2007-04-23 18:48 ` [PATCH 02/13] sync with radiotap header in wireless-2.6 Michael Wu
2007-04-23 18:48 ` [PATCH 07/13] mac80211: fix configuration concurrency issues in ieee80211_sta.c Michael Wu
2007-04-24 16:19 ` Johannes Berg
2007-04-23 18:48 ` [PATCH 04/13] mac80211: disable tasklets on close Michael Wu
2007-04-23 20:53 ` Jiri Benc
2007-04-23 18:48 ` [PATCH 06/13] mac80211: avoid flush_scheduled_work Michael Wu
2007-04-23 18:48 ` [PATCH 03/13] mac80211: fix virtual interface related locking Michael Wu
2007-04-23 20:41 ` Jiri Benc
2007-04-23 20:55 ` Michael Wu
2007-04-23 22:20 ` Michael Wu
2007-04-23 20:58 ` Andy Green
2007-04-23 21:21 ` Michael Wu
2007-04-24 18:09 ` Andy Green
2007-04-24 18:24 ` Michael Wu
2007-04-24 18:59 ` John W. Linville
2007-04-25 12:09 ` Johannes Berg
2007-04-23 18:48 ` [PATCH 05/13] mac80211: remove statistics callback for master device Michael Wu
2007-04-23 18:48 ` [PATCH 11/13] mac80211: fix issues in ieee80211 qdisc Michael Wu
2007-04-23 18:48 ` [PATCH 10/13] mac80211: set bssid to broadcast before scan Michael Wu
2007-04-24 16:24 ` Johannes Berg
2007-04-27 17:40 ` Jiri Benc
2007-04-27 19:49 ` Michael Wu
2007-04-27 21:18 ` Michael Wu
2007-04-27 21:29 ` Michael Wu
2007-04-23 18:48 ` [PATCH 08/13] mac80211: misc cleanups in ieee80211_sta.c Michael Wu
2007-04-23 18:48 ` [PATCH 12/13] mac80211: prevent master device from going up without ieee80211 qdisc Michael Wu
2007-04-23 18:48 ` [PATCH 09/13] mac80211: remove hw_scan callback Michael Wu
2007-04-24 16:20 ` Johannes Berg
2007-04-26 12:48 ` Michael Wu
2007-04-25 5:03 ` James Ketrenos
2007-04-25 18:16 ` John W. Linville
2007-04-25 20:34 ` Michael Wu
2007-04-26 21:57 ` James Ketrenos
2007-04-27 0:23 ` Michael Wu
2007-04-27 4:14 ` James Ketrenos
2007-04-27 7:44 ` Andy Green
2007-04-27 8:06 ` James Ketrenos
2007-04-27 8:54 ` Andy Green
2007-04-27 9:00 ` Jiri Benc
2007-04-27 15:32 ` Michael Wu
2007-04-29 11:55 ` Guy Cohen
2007-04-27 6:54 ` James Ketrenos
2007-04-27 14:27 ` Michael Wu
2007-05-08 17:08 ` Michael Wu
2007-04-27 14:28 ` Dan Williams
2007-04-27 14:42 ` Jiri Benc
2007-04-27 14:56 ` Dan Williams
2007-04-27 15:16 ` Andy Green
2007-04-27 15:22 ` Johannes Berg
2007-04-27 17:17 ` James Ketrenos
2007-04-27 17:49 ` Dan Williams
2007-04-27 18:09 ` Dan Williams
2007-04-27 18:52 ` Andy Green
2007-04-27 15:20 ` Jiri Benc
2007-04-27 15:30 ` Andy Green
2007-04-27 15:36 ` Jiri Benc
2007-04-27 15:52 ` Andy Green
2007-04-27 17:44 ` James Ketrenos
2007-04-27 17:02 ` James Ketrenos [this message]
2007-04-27 18:10 ` Jiri Benc
2007-04-27 19:42 ` Dan Williams
2007-04-27 19:47 ` Jiri Benc
2007-04-27 19:52 ` John W. Linville
2007-04-26 3:03 ` James Ketrenos
2007-04-27 20:47 ` James Ketrenos
2007-04-28 13:25 ` Jiri Benc
2007-04-23 18:48 ` [PATCH 13/13] mac80211: stop all virtual interfaces when master device goes down Michael Wu
2007-04-23 20:58 ` Jiri Benc
2007-04-24 16:16 ` [PATCH 01/13] mac80211: Add radiotap support Johannes Berg
2007-04-28 13:18 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46322CA9.7090606@linux.intel.com \
--to=jketreno@linux.intel.com \
--cc=dcbw@redhat.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.