From: Jeff Garzik <jeff@garzik.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <htejun@gmail.com>,
Greg KH <greg@kroah.com>
Subject: Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt
Date: Sat, 28 Apr 2007 11:14:23 -0400 [thread overview]
Message-ID: <463364CF.20801@garzik.org> (raw)
In-Reply-To: <200704260926.33826.eike-kernel@sf-tec.de>
Rolf Eike Beer wrote:
> Above and below we talk about my_midlayer_create_something, I assume that is
> also meant here.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
>
> ---
> commit bb5f6ef5bbbdc0233690fe3ba6d5787a6aab9b33
> tree cd948e03b4add89be6e648d31b7778c64a51e8d2
> parent 64aa7c3136258d3abc76354b5f83b9a9575169c0
> author Rolf Eike Beer <eike-kernel@sf-tec.de> Thu, 26 Apr 2007 09:23:39 +0200
> committer Rolf Eike Beer <eike-kernel@sf-tec.de> Thu, 26 Apr 2007 09:23:39 +0200
>
> Documentation/driver-model/devres.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
> index 5163b85..6c8d8f2 100644
> --- a/Documentation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -182,7 +182,7 @@ For example, you can do something like the following.
>
> ...
>
> - devres_close_group(dev, my_midlayer_something);
> + devres_close_group(dev, my_midlayer_create_something);
> return 0;
hmmm.
Now that devres is in the kernel, I don't think I am the best person to
merge these sort of patches. Certainly I can, and I know the code from
my original review and subsequent usage, but I think the patch is more
appropriate for Greg, going through normal maintainership channels.
IOW, I think devres is too generic to be queued via libata-dev.git.
Tejun, comments?
Jeff
next prev parent reply other threads:[~2007-04-28 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 7:26 [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt Rolf Eike Beer
2007-04-26 7:44 ` Tejun Heo
2007-04-28 15:14 ` Jeff Garzik [this message]
2007-04-29 7:50 ` Tejun Heo
2007-04-30 6:41 ` Greg KH
2007-05-01 9:00 ` [PATCH] DOC: " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463364CF.20801@garzik.org \
--to=jeff@garzik.org \
--cc=eike-kernel@sf-tec.de \
--cc=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.