From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/6] eal/linux: remove useless casts
Date: Thu, 09 Jul 2015 04:04:18 +0200 [thread overview]
Message-ID: <46336707.Mc8mLjdgqb@xps13> (raw)
In-Reply-To: <1436259634-7077-3-git-send-email-david.marchand@6wind.com>
David, there is a 32-bit failure. See below
2015-07-07 11:00, David Marchand:
> Rather than cast the huge pages number returned by get_num_hugepages, rework
> this function so that it returns 0 when something goes wrong.
> And no need for casts in log.
> --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> + RTE_LOG(INFO, EAL, "%lu hugepages of size %lu reserved, "
> + "but no mounted hugetlbfs found for that size\n",
> + num_pages, hpi->hugepage_sz);
error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘uint64_t {aka long long unsigned int}’
next prev parent reply other threads:[~2015-07-09 2:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 9:00 [PATCH 0/6] eal/linux: cleanup hugepage code David Marchand
2015-07-07 9:00 ` [PATCH 1/6] eal/linux: remove useless check on process type David Marchand
2015-07-07 9:00 ` [PATCH 2/6] eal/linux: remove useless casts David Marchand
2015-07-09 2:04 ` Thomas Monjalon [this message]
2015-07-07 9:00 ` [PATCH 3/6] eal/linux: cosmetic change David Marchand
2015-07-07 9:00 ` [PATCH 4/6] eal/linux: rework while loop David Marchand
2015-07-07 9:00 ` [PATCH 5/6] eal/linux: indent file David Marchand
2015-07-07 9:00 ` [PATCH 6/6] eal/linux: avoid out of bound access David Marchand
2015-07-08 11:03 ` [PATCH 0/6] eal/linux: cleanup hugepage code Gonzalez Monroy, Sergio
2015-07-09 9:19 ` [PATCH v2 " David Marchand
2015-07-09 9:19 ` [PATCH v2 1/6] eal/linux: remove useless check on process type David Marchand
2015-07-09 9:19 ` [PATCH v2 2/6] eal/linux: remove useless casts David Marchand
2015-07-09 9:19 ` [PATCH v2 3/6] eal/linux: cosmetic change David Marchand
2015-07-09 9:19 ` [PATCH v2 4/6] eal/linux: rework while loop David Marchand
2015-07-09 9:19 ` [PATCH v2 5/6] eal/linux: indent file David Marchand
2015-07-09 9:19 ` [PATCH v2 6/6] eal/linux: avoid out of bound access David Marchand
2015-07-09 12:21 ` [PATCH v2 0/6] eal/linux: cleanup hugepage code Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46336707.Mc8mLjdgqb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.