From: Jeff Garzik <jgarzik@pobox.com>
To: Vitaly Wool <vwool@ru.mvista.com>
Cc: dustin@sensoria.com, netdev@vger.kernel.org,
Russell King <rmk+lkml@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix smc911x compilation breakage
Date: Sat, 28 Apr 2007 11:33:15 -0400 [thread overview]
Message-ID: <4633693B.7070404@pobox.com> (raw)
In-Reply-To: <20070427143552.0000757a.vwool@ru.mvista.com>
Vitaly Wool wrote:
> Hi Jeff,
>
> currently (with 2.6.21) compilation of smc911x driver fails in the following way:
>
> CC drivers/net/smc911x.o
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c: In function `smc911x_probe':
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: warning: implicit declaration of function `set_irq_type'
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: error: `IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: error: (Each undeclared identifier is reported only once
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: error: for each function it appears in.)
> make[3]: *** [drivers/net/smc911x.o] Error 1
> make[2]: *** [drivers/net] Error 2
> make[1]: *** [drivers] Error 2
> make: *** [zImage] Error 2
>
> The patch inlined below fixes the problem.
>
> smc911x.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>
>
> Index: linux-2.6/drivers/net/smc911x.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/smc911x.c
> +++ linux-2.6/drivers/net/smc911x.c
> @@ -75,9 +75,9 @@ static const char version[] =
> #include <linux/netdevice.h>
> #include <linux/etherdevice.h>
> #include <linux/skbuff.h>
> +#include <linux/irq.h>
>
> #include <asm/io.h>
> -#include <asm/irq.h>
>
> #include "smc911x.h"
This seems to clash with rmk's comment at the top of linux/irq.h?
Jeff
next prev parent reply other threads:[~2007-04-28 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 10:35 [PATCH] fix smc911x compilation breakage Vitaly Wool
2007-04-28 15:33 ` Jeff Garzik [this message]
2007-04-28 18:10 ` Vitaly Wool
2007-04-29 8:05 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2007-04-30 16:57 [patch] " Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4633693B.7070404@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=dustin@sensoria.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=vwool@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.