From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org,
ralf@linux-mips.org, sshtylyov@ru.mvista.com,
akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX
Date: Sat, 28 Apr 2007 13:28:18 -0400 [thread overview]
Message-ID: <46338432.5060105@garzik.org> (raw)
In-Reply-To: <20070429.022428.71103613.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Sat, 28 Apr 2007 11:10:37 -0400, Jeff Garzik <jeff@garzik.org> wrote:
>>> static unsigned int netcard_portlist[] __initdata = {
>>> - 0x300, 0x280, 0x320, 0x340, 0x360, 0x380, 0
>>> +#if defined(CONFIG_ISA) || defined(CONFIG_M32R)
>>> + 0x300, 0x280, 0x320, 0x340, 0x360, 0x380,
>>> +#endif
>>> + 0
>> This looks a bit strange, and perhaps more difficult to maintain long term.
>>
>> I would suggest creating a NEEDS_PORTLIST cpp macro at the top of ne.c,
>> to be defined or undefined based on CONFIG_xxx symbols. Then, down in
>> the code itself, conditionally include or exclude all portlist related
>> data tables and code.
>>
>> Sound sane?
>
> Sure. Do you mean something like this?
Correct.
Jeff
prev parent reply other threads:[~2007-04-28 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 16:55 [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX Atsushi Nemoto
2007-04-24 17:03 ` Atsushi Nemoto
2007-04-28 15:08 ` Jeff Garzik
2007-04-28 8:04 ` Andrew Morton
2007-04-28 17:10 ` Atsushi Nemoto
2007-04-30 15:14 ` Atsushi Nemoto
2007-04-28 15:10 ` Jeff Garzik
2007-04-28 17:24 ` Atsushi Nemoto
2007-04-28 17:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46338432.5060105@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.