Re: [patch 02/10] sata_nv: add back some verbosity into ADMA error_handler

[Jeff Garzik <jeff@garzik.org>]

akpm@linux-foundation.org wrote:
> From: Robert Hancock <hancockr@shaw.ca>
> 
> Some debug output in the ADMA error_handler function was removed recently,
> but it may be useful in certain cases, like NCQ commands timing out.  Add
> it back in, but make it a bit more intelligent so that it only prints if
> command(s) are active and only prints the CPBs for those commands.  That
> way it won't spew at inappropriate times like suspend/resume.
> 
> [akpm@osdl.org: cleanup]
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/ata/sata_nv.c |   31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)

Robert, is this patch still wanted?

It looks OK; I've held because I thought it was created to debug a 
special situation.

But I might be mistaken...

	Jeff