From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: Variable "combinations" in tokenize.c and token.h
Date: Tue, 01 May 2007 21:56:24 -0700 [thread overview]
Message-ID: <463819F8.6060707@freedesktop.org> (raw)
In-Reply-To: <20070501212753.GA8539@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
Christopher Li wrote:
> On Tue, May 01, 2007 at 02:29:10PM -0700, Josh Triplett wrote:
>> Apart from triggering a -Wshadow warning, this seems somewhat wasteful.
>> The reason appears to relate to the presence or absence of a '\0'
>> terminator at the end of each item. Does that matter? Could
>> show_special change somehow to avoid the duplication? Alternatively,
>> could the global version just include '\0' terminators?
>>
>> - Josh Triplett
>>
>
> You mean some thing like that?
[snip patch]
Perfect, thanks. Applied.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2007-05-02 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 21:29 Variable "combinations" in tokenize.c and token.h Josh Triplett
2007-05-01 21:27 ` Christopher Li
2007-05-02 4:56 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463819F8.6060707@freedesktop.org \
--to=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.