All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 17/20][BNX2]: Enhance the heartbeat.
Date: Wed, 02 May 2007 03:17:20 -0400	[thread overview]
Message-ID: <46383B00.4080605@garzik.org> (raw)
In-Reply-To: <1178068656.4820.53.camel@dell>

Michael Chan wrote:
> [BNX2]: Enhance the heartbeat.
> 
> In addition to the periodic heartbeat, we're adding a heartbeat
> request interrupt when the heartbeat is late.  This is useful
> especially in -rt kernels where the timer frequently runs late.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>

Should we really be adding code for such a special situation to upstream 
code?

I lean towards "no", but defer to your and DaveM's judgement here.



  reply	other threads:[~2007-05-02  7:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02  1:17 [PATCH 17/20][BNX2]: Enhance the heartbeat Michael Chan
2007-05-02  7:17 ` Jeff Garzik [this message]
2007-05-02  7:24   ` David Miller
2007-05-02  7:38     ` Jeff Garzik
2007-05-02  7:54       ` David Miller
2007-05-02  8:01         ` Jeff Garzik
2007-05-02 17:44           ` Stephen Hemminger
2007-05-02  8:40       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46383B00.4080605@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.