From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH][XFRM] SAD info TLV aggregation
Date: Thu, 03 May 2007 02:15:10 +0200 [thread overview]
Message-ID: <4639298E.8090100@trash.net> (raw)
In-Reply-To: <1178144288.4078.5.camel@localhost>
jamal wrote:
> I am keeping the thin 32 bit header, but other than that everything is
> in one TLV. SPD info one to follow..
I think using attributes here wasn't a bad idea since this exports
things that are implementation details and might need to be changed
or extended at some point.
> enum xfrm_sadattr_type_t {
> XFRMA_SAD_UNSPEC,
> - XFRMA_SADHMASK,
> - XFRMA_SADHMAX,
> - XFRMA_SADCNT,
> + XFRMA_SADINFO,
> __XFRMA_SAD_MAX
>
> #define XFRMA_SAD_MAX (__XFRMA_SAD_MAX - 1)
> };
In any case consistent naming here would be nice (SAD_ vs. SADXXX).
next prev parent reply other threads:[~2007-05-03 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 22:18 [PATCH][XFRM] SAD info TLV aggregation jamal
2007-05-03 0:15 ` Patrick McHardy [this message]
2007-05-03 13:01 ` jamal
2007-05-03 13:15 ` Patrick McHardy
2007-05-03 13:26 ` jamal
2007-05-03 20:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4639298E.8090100@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.