All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [Fwd: Re: PATCH: libata: add support for ATA_16 on ATAPI]
Date: Thu, 03 May 2007 09:34:10 -0400	[thread overview]
Message-ID: <4639E4D2.5080108@rtr.ca> (raw)
In-Reply-To: <4639D324.5090908@pobox.com>

Jeff Garzik wrote:
> Mark Lord wrote:
>> Jeff?
>> This has been pending for a very long time now.
>>
>> This patch brings libata up to similar standards as Linux IDE
>> with support for things like hdparm -I (identify) and -C (check power)
>> among others on ATAPI drives.
>>
>> Andrew, can you pick this up for -mm ??
>>
>> ???
> 
> My reluctance stems mainly from the modifications to the hot path.  ATA 
> and ATAPI need wholly different command simulations, so I don't like 
> your modification of sending both ATA and ATAPI devices to the same 
> simulation function -- only to have to disambiguate with an ATA-or-ATAPI 
> test.
> 
> I would rather keep the branch in the queuecommand hook the same.  That 
> should keep the ATA device callpath unchanged, while enabling what you 
> want on the ATAPI callpath.

Sure thing.  Just elaborate a teensy bit more on what's going on inside
Jeff's mind, and I'll code something up to mimic.

Thanks.

      reply	other threads:[~2007-05-03 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03  2:37 [Fwd: Re: PATCH: libata: add support for ATA_16 on ATAPI] Mark Lord
2007-05-03 12:18 ` Jeff Garzik
2007-05-03 13:34   ` Mark Lord [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4639E4D2.5080108@rtr.ca \
    --to=liml@rtr.ca \
    --cc=akpm@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.