All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darrel Goeddel <dgoeddel@TrustedCS.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Xavier Toth <txtoth@gmail.com>,
	selinux@tycho.nsa.gov, Joshua Brindle <method@manicmethod.com>,
	Karl MacMillan <kmacmillan@mentalrootkit.com>
Subject: Re: launching apps at level (MLS) and polyinstantiation
Date: Thu, 03 May 2007 16:09:16 -0500	[thread overview]
Message-ID: <463A4F7C.7000302@trustedcs.com> (raw)
In-Reply-To: <1178219938.3443.209.camel@moss-spartans.epoch.ncsc.mil>

Stephen Smalley wrote:
> How about the revised patch below (only including the newrole.c and
> Makefile diffs since the hashtab code is unchanged)?  The changes from
> your patch are:
> - Make sure everything is properly enabled/disabled by USE_PAM and move
> the code into the existing USE_PAM block where appropriate.
> - Call the config file newrole_pam.conf since there could be other
> newrole config files in the future.
> - Distinguish missing config file (ok) from errors during parsing of the
> config file (should abort).
> - Remove the Authenticating <username> message since it could be
> confusing in the case where you are using a pam config that doesn't
> require it and it doesn't really provide any benefit.
> - Improve error checking and handling.
> - Coding style cleanups (indentation, comment style, etc).
> 
> To test, I created a /etc/pam.d/newrole-noauth config that had
> pam_permit.so for its auth module and created
> a /etc/selinux/newrole_pam.conf that mapped one program to
> newrole-noauth.
> 
> The alternative model would be to eliminate /etc/selnux/newrole_pam.conf
> entirely from the equation, and just have newrole look for (test via
> access()) a /etc/pam.d/newrole_<appname> config and use
> newrole_<appname> as the service name if present.

I like this idea.  I haven't had a chance to test this yet, but it looks
to be assuming that the arg to -c is just the command name without any
path info.  Should we strip that down to its basename in case someone runs
'newrole -l secret -c /usr/bin/foo' as opposed to 'newrole -l secret -c foo'?

-- 

Darrel

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2007-05-03 21:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27 18:41 launching apps at level (MLS) and polyinstantiation Ted X Toth
2007-04-27 19:01 ` Stephen Smalley
2007-04-27 19:05   ` Stephen Smalley
     [not found]     ` <463360B0.7020106@gmail.com>
     [not found]       ` <1177934887.16232.7.camel@moss-spartans.epoch.ncsc.mil>
2007-04-30 14:41         ` Ted X Toth
2007-04-30 14:52           ` Stephen Smalley
2007-05-02 15:49             ` Xavier Toth
2007-05-02 16:57               ` Stephen Smalley
2007-05-02 21:42                 ` Xavier Toth
2007-05-03 12:35                   ` Stephen Smalley
2007-05-03 13:11                 ` Xavier Toth
2007-05-03 13:40                   ` Stephen Smalley
2007-05-03 13:51                     ` Xavier Toth
2007-05-03 13:49                   ` Stephen Smalley
2007-05-03 19:18                     ` Stephen Smalley
2007-05-03 21:09                       ` Darrel Goeddel [this message]
2007-05-08 17:54                         ` Stephen Smalley
2007-05-04 18:56                       ` Ted X Toth
2007-05-04 19:23                         ` Stephen Smalley
2007-05-04 20:15                           ` Ted X Toth
2007-05-08 19:11                             ` [PATCH -trunk] newrole: enable use of alternate pam configurations for running applications in a different context (Was: Re: launching apps at level (MLS) and polyinstantiation) Stephen Smalley
2007-05-08 19:54                               ` Karl MacMillan
2007-05-11 18:42                               ` Karl MacMillan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463A4F7C.7000302@trustedcs.com \
    --to=dgoeddel@trustedcs.com \
    --cc=kmacmillan@mentalrootkit.com \
    --cc=method@manicmethod.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    --cc=txtoth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.