From: Greg Ungerer <gerg@snapgear.com>
To: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68knommu: use generic irq framework
Date: Fri, 04 May 2007 22:06:15 +1000 [thread overview]
Message-ID: <463B21B7.6090505@snapgear.com> (raw)
In-Reply-To: <20070504110655.GA2936@infradead.org>
Hi Christoph,
Christoph Hellwig wrote:
>> --- linux-2.6.21/arch/m68knommu/kernel/irq.c 1970-01-01 10:00:00.000000000 +1000
>> +++ linux-2.6.21-gt/arch/m68knommu/kernel/irq.c 2007-05-04 00:20:44.000000000 +1000
>> @@ -0,0 +1,82 @@
>> +/*
>> + * arch/m68knommu/kernel/irq.c
>
> No need for top of file filename comments, they don't provide anything
> but easily get out of sync.
Ok, I'll take that.
> Except for that little nitpick the patch looks very good to me,
> thanks a lot for doing the conversion.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2007-05-04 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 0:13 [PATCH] m68knommu: use generic irq framework Greg Ungerer
2007-05-04 11:06 ` Christoph Hellwig
2007-05-04 12:06 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463B21B7.6090505@snapgear.com \
--to=gerg@snapgear.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.