Re: git-net locking bustage

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Andrew Morton wrote:
> kernel BUG at net/netlink/af_netlink.c:144!


The BUG_ON(mutex_is_locked(nlk_sk(sk)->cb_mutex)) is bogus,
this patch removes it.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1009 bytes --]

[NETLINK]: Remove bogus BUG_ON

Remove bogus BUG_ON(mutex_is_locked(nlk_sk(sk)->cb_mutex)), when the
netlink_kernel_create caller specifies an external mutex it might
validly be locked.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit c83f581b321efb7e7119c9f906ba8ecb6c43541d
tree 4430e76db65599f1c02d1eaeec0b0606ea167175
parent 572b08f6ad7d473edd282fd40ceadbb4dce522a2
author Patrick McHardy <kaber@trash.net> Fri, 04 May 2007 21:02:24 +0200
committer Patrick McHardy <kaber@trash.net> Fri, 04 May 2007 21:02:24 +0200

 net/netlink/af_netlink.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index ac1cead..507828d 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -142,7 +142,6 @@ static void netlink_sock_destruct(struct sock *sk)
 {
 	struct netlink_sock *nlk = nlk_sk(sk);
 
-	BUG_ON(mutex_is_locked(nlk_sk(sk)->cb_mutex));
 	if (nlk->cb) {
 		if (nlk->cb->done)
 			nlk->cb->done(nlk->cb);