From: Jiri Slaby <jirislaby@gmail.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: htejun@gmail.com, akpm@osdl.org, jgarzik@pobox.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: 2.6.21-mm1: many processes end up in D state
Date: Mon, 07 May 2007 11:52:45 +0200 [thread overview]
Message-ID: <463EF6ED.7060404@gmail.com> (raw)
In-Reply-To: <200705052346.l45NksOb022632@harpo.it.uu.se>
Mikael Pettersson napsal(a):
> Jiri: please test the patch below instead. That is, revert to
> the original code _with_ the 'return 1;', and then add this
> patch to it. It should have pretty much the same effect as
> removing the 'return 1;', however calling ata_port_abort()
> is more in line with libata's new-style error handling.
>
> /Mikael
>
> --- linux-2.6.21-mm1/drivers/ata/sata_promise.c.~1~ 2007-05-05 22:24:41.000000000 +0200
> +++ linux-2.6.21-mm1/drivers/ata/sata_promise.c 2007-05-05 22:25:21.000000000 +0200
> @@ -653,6 +653,8 @@ static void pdc_error_intr(struct ata_po
> qc->err_mask |= ac_err_mask;
>
> pdc_reset_port(ap);
> +
> + ata_port_abort(ap);
> }
>
> static inline unsigned int pdc_host_intr( struct ata_port *ap,
>
Yes, no freezing anymore.
thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2007-05-07 9:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 23:46 2.6.21-mm1: many processes end up in D state Mikael Pettersson
2007-05-07 9:52 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-04 19:19 Mikael Pettersson
2007-05-05 15:30 ` Tejun Heo
2007-04-30 15:39 Jiri Slaby
2007-04-30 18:05 ` Andrew Morton
2007-04-30 18:14 ` Jiri Slaby
2007-04-30 18:44 ` Andrew Morton
2007-05-01 8:40 ` Jiri Slaby
2007-05-01 10:06 ` Jiri Slaby
2007-05-04 14:58 ` Jiri Slaby
2007-05-04 14:58 ` Jiri Slaby
2007-05-04 15:02 ` Jiri Slaby
2007-05-04 15:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463EF6ED.7060404@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.