All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] - Make mke2fs.c defaults match mke2fs.conf defaults
Date: Mon, 07 May 2007 11:31:22 -0500	[thread overview]
Message-ID: <463F545A.10903@redhat.com> (raw)

One of our testers filed a bug that said "mkfs.ext3 is much slower when mke2fs.conf is missing..."

This is because the shipped defaults in mke2fs.conf do not match the shipped defaults in the
mkfs code itself; he wound up making a 1k block filesystem on a very large block device,
for example.

So - How about this patch, to bring them back into line?  Which makes me wonder; having
"defaults" in 2 different places is bound to get out of sync; should we instead generate
both code & config file defaults (and maybe man page defaults) from a common source?

Anyway, here's a patch to bring mke2fs.conf and mke2fs.c into line for current defaults...

Thanks,
-Eric

Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Index: e2fsprogs-hg/misc/mke2fs.c
===================================================================
--- e2fsprogs-hg.orig/misc/mke2fs.c
+++ e2fsprogs-hg/misc/mke2fs.c
@@ -1288,7 +1288,8 @@ static void PRS(int argc, char *argv[])
 	tmp = tmp2 = NULL;
 	if (fs_param.s_rev_level != EXT2_GOOD_OLD_REV) {
 		profile_get_string(profile, "defaults", "base_features", 0,
-				   "filetype,sparse_super", &tmp);
+				   "sparse_super,filetype,resize_inode,dir_index",
+				   &tmp);
 		profile_get_string(profile, "fs_types", fs_type, 
 				   "base_features", tmp, &tmp2);
 		edit_feature(tmp2, &fs_param.s_feature_compat);
@@ -1365,7 +1366,7 @@ static void PRS(int argc, char *argv[])
 	
 	if (blocksize <= 0) {
 		profile_get_integer(profile, "defaults", "blocksize", 0,
-				    1024, &use_bsize);
+				    4096, &use_bsize);
 		profile_get_integer(profile, "fs_types", fs_type, 
 				    "blocksize", use_bsize, &use_bsize);
 

             reply	other threads:[~2007-05-07 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 16:31 Eric Sandeen [this message]
2007-05-07 19:47 ` [PATCH] - Make mke2fs.c defaults match mke2fs.conf defaults Theodore Tso
2007-05-07 19:52   ` Eric Sandeen
2007-05-07 21:27     ` Andreas Dilger
2007-05-08  3:38 ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463F545A.10903@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.