From: Scott Wood <scottwood@freescale.com>
To: Andy Fleming <afleming@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 12/13] gianfar: Add flags for magic packet and MDIO.
Date: Mon, 07 May 2007 16:53:04 -0500 [thread overview]
Message-ID: <463F9FC0.6030000@freescale.com> (raw)
In-Reply-To: <183F76F8-BC1B-4EB6-9C3A-4F0FFA7B3BB8@freescale.com>
Andy Fleming wrote:
> Hrm. I don't think this is a good way to go. The DEV* flags are all
> features right now, rather than configuration settings. It seems like
> this is a stop-gap solution for until more robust detection of the
> ability to power down the interface. I can understand that a full
> solution might be beyond the ambitions of this first set of patches,
> but I'd prefer if we didn't pollute gianfar's device flags space with a
> flag that we should aim at removing eventually.
I'd rather "pollute" an existing flags with something that can be
removed (and the bit reused, if you're concerned about that) later, than
add a completely new field to accomplish the same thing.
And like the other DEV flags, it's an attribute of the device as it
exists in the system.
-Scott
next prev parent reply other threads:[~2007-05-07 21:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 18:29 [PATCH 01/13] Clean up formatting in Documentation/booting-without-of.txt Scott Wood
2007-05-07 18:29 ` [PATCH 02/13] Document devtree binding for power management controllers Scott Wood
2007-05-08 0:19 ` David Gibson
2007-05-07 18:29 ` [PATCH 03/13] Document the sleep property Scott Wood
2007-05-08 2:11 ` Olof Johansson
2007-05-08 15:23 ` Scott Wood
2007-05-07 18:29 ` [PATCH 04/13] Document the devtree binding for general purpose timers Scott Wood
2007-05-07 18:29 ` [PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes Scott Wood
2007-05-07 21:27 ` Andy Fleming
2007-05-07 21:29 ` Scott Wood
2007-05-07 21:51 ` Andy Fleming
2007-05-07 23:06 ` Kumar Gala
2007-05-08 0:18 ` David Gibson
2007-05-09 14:33 ` Segher Boessenkool
2007-05-09 18:26 ` Scott Wood
2007-05-10 6:57 ` Segher Boessenkool
2007-05-08 15:29 ` Scott Wood
2007-05-07 18:29 ` [PATCH 06/13] Make swsusp_32.S usable for suspend-to-RAM Scott Wood
2007-05-07 18:29 ` [PATCH 07/13] Implement arch disable/enable irq hooks Scott Wood
2007-05-21 15:55 ` Johannes Berg
2007-05-22 7:14 ` Benjamin Herrenschmidt
2007-05-22 9:03 ` Johannes Berg
2007-05-22 9:15 ` Benjamin Herrenschmidt
2007-05-22 9:24 ` Johannes Berg
2007-05-07 18:29 ` [PATCH 08/13] pm: Handle HID0_SLEEP in the TLF_NAPPING hack Scott Wood
2007-05-07 18:29 ` [PATCH 09/13] fsl_soc: Factor fsl_get_bus_freq() out of the wdt init Scott Wood
2007-05-10 3:36 ` Kumar Gala
2007-05-10 15:49 ` Scott Wood
2007-05-10 15:59 ` Kumar Gala
2007-05-07 18:29 ` [PATCH 10/13] mpc83xx: Power Management support Scott Wood
2007-05-22 21:08 ` Guennadi Liakhovetski
2007-05-22 21:16 ` Scott Wood
2007-05-07 18:29 ` [PATCH 11/13] mpc83xx: timer driver for PM wakeup Scott Wood
2007-05-07 18:29 ` [PATCH 12/13] gianfar: Add flags for magic packet and MDIO Scott Wood
2007-05-07 19:52 ` Kumar Gala
2007-05-07 19:54 ` Scott Wood
2007-05-07 20:00 ` Kumar Gala
2007-05-07 21:25 ` Andy Fleming
2007-05-07 21:31 ` Scott Wood
2007-05-07 21:56 ` Andy Fleming
2007-05-07 21:45 ` Andy Fleming
2007-05-07 21:53 ` Scott Wood [this message]
2007-05-07 21:59 ` Andy Fleming
2007-05-07 23:11 ` Kumar Gala
2007-05-07 23:36 ` Andy Fleming
2007-05-07 18:30 ` [PATCH 13/13] gianfar: Magic Packet and suspend/resume support Scott Wood
2007-05-08 0:20 ` [PATCH 01/13] Clean up formatting in Documentation/booting-without-of.txt David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463F9FC0.6030000@freescale.com \
--to=scottwood@freescale.com \
--cc=afleming@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.