From: "Kristian Høgsberg" <krh@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
Kristian H??gsberg <krh@redhat.com>,
John Stoffel <john@stoffel.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux1394-devel <linux1394-devel@lists.sourceforge.net>
Subject: Re: [PATCH 3/6] firewire: char device interface
Date: Mon, 07 May 2007 20:19:03 -0400 [thread overview]
Message-ID: <463FC1F7.7090806@redhat.com> (raw)
In-Reply-To: <20070504094817.GA31811@infradead.org>
Christoph Hellwig wrote:
> On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote:
>> The firewire-cdev.h file is meant to be a self-contained userspace header
>> file and shouldn't include other kernel header files. All duplicated
>> values are standardized ieee1394 values and won't ever change. I should
>> put a #ifndef __FW_COMMON_DEFINES protection around the duplicate values, I
>> guess, but I'm just wondering why I never saw a "symbol redefined"
>> warning...
>
> No, defining things in two places is not okay. Just add a new header
> that defines these protocol constants, which needs to be included by
> userspace that wants to use them.
Ok, I split out the shared constants into linux/firewire-constants.h which
gets included by linux/firewire-cdev.h.
Kristian
next prev parent reply other threads:[~2007-05-08 0:21 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 20:27 [git pull] New firewire stack Kristian Høgsberg
2007-05-01 21:34 ` Stefan Richter
2007-05-02 9:00 ` Christoph Hellwig
2007-05-02 12:13 ` Stefan Richter
2007-05-02 12:15 ` [PATCH 1/6] firewire: handling of cards, buses, nodes Stefan Richter
2007-05-02 12:16 ` [PATCH 2/6] firewire: isochronous and asynchronous I/O Stefan Richter
2007-05-02 12:17 ` [PATCH 3/6] firewire: char device interface Stefan Richter
2007-05-02 12:18 ` [PATCH 4/6] firewire: OHCI-1394 lowlevel driver Stefan Richter
2007-05-02 12:18 ` [PATCH 5/6] firewire: SBP-2 highlevel driver Stefan Richter
2007-05-02 12:19 ` [PATCH 6/6] firewire: add it all to kbuild Stefan Richter
2007-05-02 18:05 ` Stefan Richter
2007-05-02 19:44 ` Christoph Hellwig
2007-05-02 23:01 ` Stefan Richter
2007-05-03 4:15 ` Sam Ravnborg
2007-05-03 8:10 ` Christoph Hellwig
2007-05-08 0:14 ` Kristian Høgsberg
2007-05-02 19:44 ` [PATCH 5/6] firewire: SBP-2 highlevel driver Christoph Hellwig
2007-05-02 21:53 ` Stefan Richter
2007-05-02 22:10 ` Stefan Richter
2007-05-04 9:53 ` Christoph Hellwig
2007-05-04 11:20 ` Stefan Richter
2007-05-09 21:05 ` Kristian Høgsberg
2007-05-09 21:48 ` Stefan Richter
2007-05-09 21:57 ` Stefan Richter
2007-05-09 22:13 ` Kristian Høgsberg
2007-05-09 22:56 ` Stefan Richter
2007-05-04 11:11 ` [PATCH 4/6] firewire: OHCI-1394 lowlevel driver Christoph Hellwig
2007-05-09 23:40 ` Kristian Høgsberg
2007-05-02 15:35 ` [PATCH 3/6] firewire: char device interface John Stoffel
2007-05-02 16:06 ` Stefan Richter
2007-05-02 21:11 ` Kristian Høgsberg
2007-05-04 9:48 ` Christoph Hellwig
2007-05-08 0:19 ` Kristian Høgsberg [this message]
2007-05-02 19:30 ` Christoph Hellwig
2007-05-08 0:08 ` Kristian Høgsberg
2007-05-02 19:29 ` [PATCH 2/6] firewire: isochronous and asynchronous I/O Christoph Hellwig
2007-05-03 0:08 ` Kristian Høgsberg
2007-05-03 8:54 ` Stefan Richter
2007-05-02 15:55 ` [PATCH 1/6] firewire: handling of cards, buses, nodes Pekka Enberg
2007-05-02 19:16 ` Stefan Richter
2007-05-02 20:35 ` Pekka Enberg
2007-05-07 22:02 ` Kristian Høgsberg
2007-05-02 21:16 ` Kristian Høgsberg
2007-05-02 19:22 ` Christoph Hellwig
2007-05-07 23:42 ` Kristian Høgsberg
2007-05-02 20:00 ` [git pull] New firewire stack Kristian Høgsberg
2007-05-02 12:21 ` Olaf Hering
2007-05-02 12:48 ` Stefan Richter
2007-05-02 13:56 ` Gene Heskett
2007-05-02 18:51 ` Stefan Richter
2007-05-02 15:27 ` Adrian Bunk
2007-05-02 20:03 ` Kristian Høgsberg
2007-05-02 19:53 ` Kristian Høgsberg
2007-05-02 20:03 ` Olaf Hering
2007-05-10 17:26 ` [git pull] New firewire stack (updated) Stefan Richter
2007-05-10 17:38 ` Christoph Hellwig
2007-05-10 17:51 ` Adrian Bunk
2007-05-10 17:56 ` Stefan Richter
2007-05-10 18:05 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463FC1F7.7090806@redhat.com \
--to=krh@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=john@stoffel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.