From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 1/2] skge: default WOL should be magic only
Date: Tue, 08 May 2007 01:06:34 -0400 [thread overview]
Message-ID: <4640055A.5000502@garzik.org> (raw)
In-Reply-To: <20070507110036.050e7b5b@freekitty>
Stephen Hemminger wrote:
> By default, the skge driver now enables wake on magic and wake on PHY.
> This is a bad default (bug), wake on PHY means machine will never shutdown
> if connected to a switch.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>a
>
> ---
> drivers/net/skge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- sky2-2.6.21.orig/drivers/net/skge.c 2007-05-07 10:01:47.000000000 -0700
> +++ sky2-2.6.21/drivers/net/skge.c 2007-05-07 10:03:29.000000000 -0700
> @@ -3591,7 +3591,7 @@ static struct net_device *skge_devinit(s
> skge->duplex = -1;
> skge->speed = -1;
> skge->advertising = skge_supported_modes(hw);
> - skge->wol = pci_wake_enabled(hw->pdev) ? wol_supported(hw) : 0;
> + skge->wol = pci_wake_enabled(hw->pdev) ? WAKE_MAGIC : 0;
NAK. You still need to check for buggy chips (as in patch #2)
If stable@kernel.org applied this, they need to fix it as you will for
upstream...
Jeff
next prev parent reply other threads:[~2007-05-08 5:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 18:00 [PATCH 1/2] skge: default WOL should be magic only Stephen Hemminger
2007-05-08 5:06 ` Jeff Garzik [this message]
2007-05-08 20:36 ` [PATCH 1/2] skge: default WOL should be magic only (rev2) Stephen Hemminger
2007-05-09 23:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4640055A.5000502@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.