All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] tc35815: Remove unnecessary skb->dev assignment
Date: Tue, 08 May 2007 01:42:15 -0400	[thread overview]
Message-ID: <46400DB7.1080500@garzik.org> (raw)
In-Reply-To: <20070508.004604.108738613.anemo@mba.ocn.ne.jp>

Atsushi Nemoto wrote:
> Apply changes in commit 4c13eb6657fe9ef7b4dc8f1a405c902e9e5234e0 to
> newly added piece of code.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index f1e2dfc..463d600 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -540,7 +540,6 @@ static struct sk_buff *alloc_rxbuf_skb(struct net_device *dev,
>  	skb = dev_alloc_skb(RX_BUF_SIZE);
>  	if (!skb)
>  		return NULL;
> -	skb->dev = dev;
>  	*dma_handle = pci_map_single(hwdev, skb->data, RX_BUF_SIZE,
>  				     PCI_DMA_FROMDEVICE);

applied



      reply	other threads:[~2007-05-08  5:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 15:46 [PATCH] tc35815: Remove unnecessary skb->dev assignment Atsushi Nemoto
2007-05-08  5:42 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46400DB7.1080500@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.