From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Martin Spinler" <spinler@cesnet.cz>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Wathsala Vithanage" <wathsala.vithanage@arm.com>
Subject: Re: [PATCH] net/nfb: fix use after free
Date: Thu, 10 Oct 2024 19:25:11 +0200 [thread overview]
Message-ID: <4642040.8F6SAcFxjW@thomas> (raw)
In-Reply-To: <CAJFAV8z04AWci67nHWXv=qG6_oj53njHqkjNVy1qvdmfG8WWog@mail.gmail.com>
10/10/2024 19:17, David Marchand:
> On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > With the annotations added to the allocation functions,
> > more issues are detected at compilation time:
> >
> > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free'
> >
> > It is fixed by moving the assignment before freeing the parent pointer.
> >
> > Fixes: 80da7efbb4c4 ("eal: annotate allocation functions")
The real cause is:
Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied to fix compilation on the main branch.
next prev parent reply other threads:[~2024-10-10 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 17:15 [PATCH] net/nfb: fix use after free Thomas Monjalon
2024-10-10 17:17 ` David Marchand
2024-10-10 17:25 ` Thomas Monjalon [this message]
2024-10-11 11:50 ` Martin Spinler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4642040.8F6SAcFxjW@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=spinler@cesnet.cz \
--cc=stephen@networkplumber.org \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.