All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	NeilBrown <neilb@suse.de>, Adrian Bunk <bunk@stusta.de>
Subject: [bisect] NFS regression breaks X
Date: Wed, 09 May 2007 17:30:10 -0400	[thread overview]
Message-ID: <46423D62.2070200@garzik.org> (raw)


Original bug report, with hardware and software info:
http://lkml.org/lkml/2007/5/8/667

I love bisect :)  bisect has identified the following commit as the one 
that causes my GNOME login to die, within 10 seconds of logging in:

	commit 2bea90d43a050bbc4021d44e59beb34f384438db
	Author: Chuck Lever <chuck.lever@oracle.com>
	Date:   Thu Mar 29 16:47:53 2007 -0400

	SUNRPC: RPC buffer size estimates are too large

100% reproducible, verified regression.  My home directory is an NFSv4 
mount, and the problem appears on my client workstation, so this makes 
some sense:
> sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw)
> pretzel:/ on /g type nfs4 (rw,noatime,proto=tcp,addr=10.10.10.1)



As an aside, let me express the hope that the NFS developers develop 
better patch creation methods.  My bisect compile repeatedly died at

>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CHK     include/linux/compile.h
> fs/nfs/pagelist.c:239: error: conflicting types for ‘nfs_pageio_init’
> include/linux/nfs_page.h:80: error: previous declaration of ‘nfs_pageio_init’ was here
> make[2]: *** [fs/nfs/pagelist.o] Error 1
> make[1]: *** [fs/nfs] Error 2
> make: *** [fs] Error 2

which indicates that someone on the NFS team did not create 
wholly-contained patches when submitted to the kernel.  Build breakage 
should not be fixed in a later commit (unless the breakage already went 
upstream), because -- as we see here -- it breaks bisection.

	Jeff, occasionally guilty of same, and trying to reform



             reply	other threads:[~2007-05-09 21:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-09 21:30 Jeff Garzik [this message]
2007-05-09 21:51 ` [bisect] NFS regression breaks X Linus Torvalds
2007-05-09 22:17   ` Trond Myklebust
2007-05-09 22:48   ` Jeff Garzik
2007-05-09 22:03 ` Trond Myklebust
2007-05-09 22:52   ` Andrew Morton
2007-05-10  0:10     ` Trond Myklebust
2007-05-10 13:36       ` Chuck Lever
2007-05-11 22:54       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46423D62.2070200@garzik.org \
    --to=jeff@garzik.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.