Re: [PATCH] libata-acpi: fix _GTF command protocol for ATAPI devices

[Jeff Garzik <jeff@garzik.org>]

Tejun Heo wrote:
> _GTF command is never ATA_PROT_ATAPI_NODATA whether the device is
> ATAPI or not.  It's always ATA_PROT_NODATA.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>  drivers/ata/libata-acpi.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index 03a0acf..cb3eab6 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -489,8 +489,7 @@ static void taskfile_load_raw(struct ata_port *ap,
>  
>  	/* convert gtf to tf */
>  	tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; /* TBD */
> -	tf.protocol = atadev->class == ATA_DEV_ATAPI ?
> -		ATA_PROT_ATAPI_NODATA : ATA_PROT_NODATA;
> +	tf.protocol = ATA_PROT_NODATA;
>  	tf.feature = gtf->tfa[0];	/* 0x1f1 */
>  	tf.nsect   = gtf->tfa[1];	/* 0x1f2 */
>  	tf.lbal    = gtf->tfa[2];	/* 0x1f3 */

applied