From: Jeff Garzik <jeff@garzik.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org, akpm@google.com, alan@redhat.com
Subject: Re: [PATCH] Fix pata_qdi.c probe code
Date: Wed, 09 May 2007 20:17:50 -0400 [thread overview]
Message-ID: <464264AE.4020407@garzik.org> (raw)
In-Reply-To: <20070503093025.GB3595@implementation.labri.fr>
Samuel Thibault wrote:
> Hi,
>
> There is a small typo in the probe code of pata_qdi.c, here is a patch.
>
> Samuel
>
>
> ------------------------------------------------------------------------
>
> diff --git a/drivers/ata/pata_qdi.c b/drivers/ata/pata_qdi.c
> index 27685ce..fb8c9e1 100644
> --- a/drivers/ata/pata_qdi.c
> +++ b/drivers/ata/pata_qdi.c
> @@ -375,7 +375,7 @@ static __init int qdi_init(void)
> res = inb(port + 3);
> if (res & 1) {
> /* Single channel mode */
> - if (qdi_init_one(port, 6580, ide_port[r & 0x01], ide_irq[r & 0x01], r & 0x04))
> + if (qdi_init_one(port, 6580, ide_port[r & 0x01], ide_irq[r & 0x01], r & 0x04) == 0)
> ct++;
applied
prev parent reply other threads:[~2007-05-10 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 9:30 [PATCH] Fix pata_qdi.c probe code Samuel Thibault
2007-05-10 0:17 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464264AE.4020407@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@google.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.