Re: [PATCH 3/4] stex: fix reset recovery for console device

[Jeff Garzik <jeff@garzik.org>]

Ed Lin wrote:
> After reset completed, the scsi error handler sends out TEST_UNIT_READY
> to the device. For 'normal' devices the command will be handled by firmware.
> However, because the RAID console only interfaces to scsi mid layer, the
> firmware will not process the command for it. This will make the console to
> be offlined right after reset. Add the handling in driver to fix this problem.
> 
> Signed-off-by: Ed Lin <ed.lin@promise.com>
> ---
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 81dd3b7..47c2ef9 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -612,6 +612,13 @@ stex_queuecommand(struct scsi_cmnd *cmd,
>  			return 0;
>  		}
>  		break;
> +	case TEST_UNIT_READY:
> +		if (id == host->max_id - 1) {
> +			cmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8;
> +			done(cmd);
> +			return 0;
> +		}
> +		break;

Long term, it seems like a more obvious separation between the RAID 
console and the firmware-handled devices would be useful, rather than 
repeating the "if (id == host->max_id - 1)" for each command in question.