From: Rene Herman <rene.herman@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: bunk@stusta.de, randy.dunlap@oracle.com,
akpm@linux-foundation.org, rpjday@mindspring.com,
alan@lxorguk.ukuu.org.uk, marcel@holtmann.org, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] module_author: don't advice putting in an email address
Date: Fri, 11 May 2007 02:50:58 +0200 [thread overview]
Message-ID: <4643BDF2.9030105@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Hi Rusty.
Following up the recent MODULE_MAINTAINER discussion:
http://lkml.org/lkml/2007/4/4/170
that concluded with MODULE_MAINTAINER not being a good idea, here's a small
patch that just deletes the advice of including an email address in the
MODULE_AUTHOR tag as suggested (and not objected to) at the end of it.
The email address is the problem I was trying to fix; with multiple current
and non-current authors and maintainers who might not even be authors the
address(es) available from the tag confuse the issue of whom to contact.
It's moreover also information that easily outdated.
A bit more than half of the tags in the tree don't include an email address
already and I'll submit patches removing more...
Rene.
[-- Attachment #2: module_author.diff --]
[-- Type: text/plain, Size: 1029 bytes --]
commit 3b4fa382d5a6a3d9afdcb5a9232d63c47391fb30
Author: Rene Herman <rene.herman@gmail.com>
Date: Fri May 11 02:24:35 2007 +0200
module_author: don't advice putting in an email address
It's information that's easily outdated and easily mistaken for
a driver contact which is a problem especially for modules with
multiple current and non-current authors as well as for modules
with a maintainer who may not even be a module author.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
diff --git a/include/linux/module.h b/include/linux/module.h
index 792d483..e6e0f86 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -124,7 +124,7 @@ extern struct module __this_module;
*/
#define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
-/* Author, ideally of form NAME <EMAIL>[, NAME <EMAIL>]*[ and NAME <EMAIL>] */
+/* Author, ideally of form NAME[, NAME]*[ and NAME] */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
/* What your module does. */
next reply other threads:[~2007-05-11 0:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 0:50 Rene Herman [this message]
2007-05-11 10:46 ` [PATCH] module_author: don't advice putting in an email address Alan Cox
2007-05-11 11:42 ` John Anthony Kazos Jr.
2007-05-11 20:50 ` Rene Herman
2007-05-11 21:18 ` Adrian Bunk
2007-05-11 21:35 ` Alan Cox
2007-05-12 7:14 ` Adrian Bunk
2007-05-12 12:15 ` Alan Cox
2007-05-12 12:38 ` Adrian Bunk
2007-05-11 14:16 ` Rene Herman
2007-05-11 14:40 ` Alan Cox
2007-05-11 17:21 ` Rene Herman
2007-05-11 23:23 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4643BDF2.9030105@gmail.com \
--to=rene.herman@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=randy.dunlap@oracle.com \
--cc=rpjday@mindspring.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.