All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus@drzeus.cx>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] mmc: add include <linux/mmc/mmc.h> to au1xmmc.c
Date: Fri, 11 May 2007 06:47:56 +0200	[thread overview]
Message-ID: <4643F57C.5060409@drzeus.cx> (raw)
In-Reply-To: <20070511125919.350c53a8.yoichi_yuasa@tripeaks.co.jp>

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Yoichi Yuasa wrote:
> Hi,
> 
> This patch has fixed the following error about au1xmmc.c .
> 
> drivers/mmc/host/au1xmmc.c: In function 'au1xmmc_send_command':
> drivers/mmc/host/au1xmmc.c:217: error: 'MMC_READ_SINGLE_BLOCK' undeclared (first use in this function)
> drivers/mmc/host/au1xmmc.c:217: error: (Each undeclared identifier is reported only once
> drivers/mmc/host/au1xmmc.c:217: error: for each function it appears in.)
> drivers/mmc/host/au1xmmc.c:218: error: 'SD_APP_SEND_SCR' undeclared (first use in this function)
> drivers/mmc/host/au1xmmc.c:221: error: 'MMC_READ_MULTIPLE_BLOCK' undeclared (first use in this function)
> drivers/mmc/host/au1xmmc.c:224: error: 'MMC_WRITE_BLOCK' undeclared (first use in this function)
> drivers/mmc/host/au1xmmc.c:228: error: 'MMC_WRITE_MULTIPLE_BLOCK' undeclared (first use in this function)
> drivers/mmc/host/au1xmmc.c:231: error: 'MMC_STOP_TRANSMISSION' undeclared (first use in this function)
> 
> Yoichi
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> 

NAK for now. I want an explanation what those opcodes are doing in a host driver.

Rgds
Pierre



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

  reply	other threads:[~2007-05-11  4:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  3:59 [PATCH] mmc: add include <linux/mmc/mmc.h> to au1xmmc.c Yoichi Yuasa
2007-05-11  4:47 ` Pierre Ossman [this message]
2007-05-11  5:16   ` Yoichi Yuasa
2007-05-11  5:20     ` Pierre Ossman
2007-05-11 10:29       ` [PATCH] mmc: au1xmmc command types check from data flags Yoichi Yuasa
2007-05-11 11:07         ` Manuel Lauss
2007-05-11 11:27           ` Yoichi Yuasa
2007-05-11 15:48         ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4643F57C.5060409@drzeus.cx \
    --to=drzeus@drzeus.cx \
    --cc=linux-mips@linux-mips.org \
    --cc=yoichi_yuasa@tripeaks.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.