From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from jazzhorn.ncsc.mil (mummy.ncsc.mil [144.51.88.129]) by tarius.tycho.ncsc.mil (8.13.1/8.13.1) with SMTP id l4BFSVqr031497 for ; Fri, 11 May 2007 11:28:31 -0400 Received: from exchange.columbia.tresys.com (jazzhorn.ncsc.mil [144.51.5.9]) by jazzhorn.ncsc.mil (8.12.10/8.12.10) with SMTP id l4BFSNuh020244 for ; Fri, 11 May 2007 15:28:23 GMT Message-ID: <46448B61.9080808@manicmethod.com> Date: Fri, 11 May 2007 11:27:29 -0400 From: Joshua Brindle MIME-Version: 1.0 To: Karl MacMillan CC: Brian Pomerantz , selinux@tycho.nsa.gov Subject: Re: [PATCH] Basic policy representation References: <46408CF6.1050409@manicmethod.com> <1178636917.25354.28.camel@localhost.localdomain> <46409BB6.7040500@manicmethod.com> <1178640671.25354.49.camel@localhost.localdomain> <20070508164741.GA29479@skull.piratehaven.org> <1178653280.3155.6.camel@localhost.localdomain> <1178719410.2379.32.camel@localhost.localdomain> In-Reply-To: <1178719410.2379.32.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov Karl MacMillan wrote: > On Tue, 2007-05-08 at 15:41 -0400, Karl MacMillan wrote: > >> I actually prefer returning char instead - to me that is a common way to >> indicate that the returned value has a limited range of values (2 in >> this case). But maybe that is just the code bases I've worked on. I >> don't care either way - this seems like a bike shed discussion . . . >> >> > > On the other hand, the existing code (for things like sepol_bool) uses > int for boolean values. So I'll change to using int everywhere. > Ahh . . . the bike shed looks much nicer painted blue rather than green. > Not to drag this mostly irrelevant discussion out longer but the setools guys have decided to move to using stdbool.h and proper bool types for all their boolean functions, is there a reason we can't do that? I was surprised to find out that setting a bool value to anything other than 0 would cause it to be 1, so it really behaves like a boolean (strange.. I'm not use to C doing things the way you'd expect them to :P ) Also the bikeshed should be red. -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.