Re: + timer_stats-slimmed-down-using-statistics-infrastucture.patch added to -mm tree

[Martin Peschke <mp3@de.ibm.com>]

Arjan van de Ven wrote:
> On Fri, 2007-04-20 at 17:18 -0700, akpm@linux-foundation.org wrote:
>> The patch titled
>>      timer_stats slimmed down: using statistics infrastucture
>> has been added to the -mm tree.  Its filename is
>>      timer_stats-slimmed-down-using-statistics-infrastucture.patch
>>
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>>
>> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
>> out what to do about this
>>
>> ------------------------------------------------------
>> Subject: timer_stats slimmed down: using statistics infrastucture
>> From: Martin Peschke <mp3@de.ibm.com>
>>
>> This patch implements timer_stats based on the statistics infrastructure.
>>
>> Here is some sample output, which even somewhat
>> resembles /proc/timer_stats.
>> (>80 char lines because of symbol names, sorry for line breaks).
>>
>> It reads:
>> <statistic name> <basket> <hits> <label>
>>
>> with label being:
>> <pid> <task name> <start_fn>(<stop_fn>)
>>
>> [root@t2930041 timer_stats]# cat data
> 
> this patch changes the userspace API though, and breaks PowerTOP :(

Though I think it was unfortunate to add the "old" proc API in 2.6.21.
timer_stats is clearly labeled as debug stuff in config help, which is why 
debugfs would have been a proper place.