All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@linux.vnet.ibm.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com
Subject: Re: [PATCH 3/19] ipr: convert to use the data buffer accessors
Date: Mon, 14 May 2007 10:27:44 -0500	[thread overview]
Message-ID: <46487FF0.7030502@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070512182921I.fujita.tomonori@lab.ntt.co.jp>

FUJITA Tomonori wrote:
> @@ -550,12 +550,7 @@ struct ipr_cmnd *ipr_get_free_ipr_cmnd(s
>  static void ipr_unmap_sglist(struct ipr_ioa_cfg *ioa_cfg,
>  			     struct ipr_cmnd *ipr_cmd)
>  {
> -	struct scsi_cmnd *scsi_cmd = ipr_cmd->scsi_cmd;
> -
> -	if (ipr_cmd->dma_use_sg)
> -		pci_unmap_sg(ioa_cfg->pdev, scsi_cmd->request_buffer,
> -			     scsi_cmd->use_sg,
> -			     scsi_cmd->sc_data_direction);
> +	scsi_dma_unmap(&ioa_cfg->pdev->dev, ipr_cmd->scsi_cmd);
>  }

You can completely do away with ipr_unmap_sglist and just call
scsi_dma_unmap directly instead.

Thanks,

Brian

  reply	other threads:[~2007-05-14 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12 10:05 [PATCH 3/19] ipr: convert to use the data buffer accessors FUJITA Tomonori
2007-05-14 15:27 ` Brian King [this message]
2007-05-14 22:37   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46487FF0.7030502@linux.vnet.ibm.com \
    --to=brking@linux.vnet.ibm.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.