From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Andrew Morton <akpm@linux-foundation.org>,
rmk@arm.linux.org.uk, Andi Kleen <ak@suse.de>,
bjorn.helgaas@hp.com
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend
Date: Mon, 14 May 2007 10:57:36 -0700 [thread overview]
Message-ID: <4648A310.1050908@sun.com> (raw)
In-Reply-To: <46489BC2.6040403@sun.com>
[PATCH] serial: set RTS and DTR if flow is 'r'
if the serial console flow is set to 'r', We need to set RTS and DTR.
Some UARTs on other side need these bit set, otherwise will not send
char to or
receive char from the host that kernel is runing esp for kernel boot stage.
BTW:
earlyprintk and early_uart are hard coded to set DTR/RTS.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Andi Kleen <ak@suse.de>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 48e259a..4e6f8be 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2154,6 +2154,15 @@ serial8250_set_termios(struct uart_port *port,
struct ktermios *termios,
}
serial_outp(up, UART_FCR, fcr); /* set fcr */
}
+
+ /* if serial console flow is 'r', we need to set RTS and DTR to MCR.
+ * some uarts on other side don't support no flow control. So we state
+ * console=ttyS0,9600n8r in kernel command line to make those uart can
+ * work.
+ */
+ if (termios->c_cflag & CRTSCTS)
+ up->port.mctrl |= TIOCM_RTS | TIOCM_DTR;
+
serial8250_set_mctrl(&up->port, up->port.mctrl);
spin_unlock_irqrestore(&up->port.lock, flags);
}
next prev parent reply other threads:[~2007-05-14 17:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-13 5:33 [PATCH]x86_64: build and use GDT on copied compressed kernel Yinghai Lu
2007-05-13 5:52 ` Andi Kleen
2007-05-13 6:41 ` Yinghai Lu
2007-05-13 6:09 ` Eric W. Biederman
2007-05-13 6:29 ` Yinghai Lu
2007-05-13 6:48 ` Eric W. Biederman
2007-05-13 6:55 ` Yinghai Lu
2007-05-13 7:06 ` Eric W. Biederman
2007-05-13 7:27 ` Yinghai Lu
2007-05-13 18:01 ` Yinghai Lu
2007-05-13 19:49 ` Eric W. Biederman
2007-05-13 21:06 ` Yinghai Lu
2007-05-13 21:23 ` Eric W. Biederman
2007-05-14 17:26 ` [PATCH] serial: set RTS and DTR if flow is 'r' Yinghai Lu
2007-05-14 17:54 ` Randy Dunlap
2007-05-14 17:57 ` Yinghai Lu [this message]
2007-05-14 18:10 ` [PATCH] serial: set RTS and DTR if flow is 'r' --- resend Russell King
2007-05-14 19:04 ` Yinghai Lu
2007-05-14 19:19 ` Russell King
2007-05-14 19:46 ` Yinghai Lu
2007-05-14 19:50 ` Russell King
2007-05-14 20:04 ` Yinghai Lu
2007-05-15 20:48 ` [PATCH] serial: set DTR in uart for kernel serial console Yinghai Lu
2007-05-22 19:31 ` PATCH] serial: convert early_uart to earlycon for 8250 Yinghai Lu
2007-05-28 10:51 ` Russell King
2007-05-28 17:50 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4648A310.1050908@sun.com \
--to=yinghai.lu@sun.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.