From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ky Srinivasan" Subject: Re: [PATCH] PV driver compatibility patch Date: Tue, 15 May 2007 11:26:31 -0600 Message-ID: <4649A4B5.E57C.0030.0@novell.com> References: <46499FCB.E57C.0030.0@novell.com> <1179249116.26437.39.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1179249116.26437.39.camel@localhost.localdomain> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Ian, Ignore my earlier email. The sles10 sp1 code is based on older code and = does not have the stuff you have in compat shim. I ran into this problem = when trying to build a PV driver targeted against RHEL5 and ran into this = problem. Regards, K. Y >>> On Tue, May 15, 2007 at 1:11 PM, in message <1179249116.26437.39.camel@localhost.localdomain>, Ian Campbell wrote:=20 > Isn't there already enough compat shim in > unmodified_drivers/linux- 2.6/compat- include/xen/platform- compat.h for > this stuff? >=20 > xenbus_probe.c already has the required #include, what is the error you > saw? >=20 > Ian. >=20 > On Tue, 2007- 05- 15 at 11:05 - 0600, Ky Srinivasan wrote: >> This patch fixes compilation issues on 2.6.16 kernels. >>=20 >> Signed- off- by: K. Y. Srinivasan >>=20 >=20 >=20 >> --- >> linux- 2.6- xen- sparse/drivers/xen/xenbus/xenbus_probe.c 2007- = 05- 14 >> 13:45:04.000000000 - 0400 >> +++ >> linux- 2.6- xen- sparse- new/drivers/xen/xenbus/xenbus_probe.c 2007- = 05- 15 >> 10:55:31.000000000 - 0400 >> @@ - 67,8 +67,11 @@ >> static unsigned long xen_store_mfn; >> =20 >> extern struct mutex xenwatch_mutex; >> - >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,17) >> +static struct notifier_block *xenstore_chain; >> +#else >> static ATOMIC_NOTIFIER_HEAD(xenstore_chain); >> +#endif